Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/11791 )
Change subject: mainboard/lenovo/t410: Add new port
......................................................................
Patch Set 22:
(3 comments)
https://review.coreboot.org/c/coreboot/+/11791/10/src/mainboard/lenovo/t410/...
File src/mainboard/lenovo/t410/romstage.c:
https://review.coreboot.org/c/coreboot/+/11791/10/src/mainboard/lenovo/t410/...
PS10, Line 235: reg32 = inl(DEFAULT_PMBASE + 0x04);
That should be moved to src/southbridge/intel/common . It's the same on all generations...
removed code
https://review.coreboot.org/c/coreboot/+/11791/10/src/mainboard/lenovo/t410/...
PS10, Line 260: write_acpi16(0x2, 0x0);
southbridge specific code
removed code
https://review.coreboot.org/c/coreboot/+/11791/21/src/mainboard/lenovo/t410/...
File src/mainboard/lenovo/t410/romstage.c:
https://review.coreboot.org/c/coreboot/+/11791/21/src/mainboard/lenovo/t410/...
PS21, Line 204:
: /* This should probably go away. Until now it is required
: * and mainboard specific
: */
This fits in one line, and there's two empty lines beforehand
removed code
--
To view, visit
https://review.coreboot.org/c/coreboot/+/11791
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9d872e643dd242e925bfb46d18076e6ad100995
Gerrit-Change-Number: 11791
Gerrit-PatchSet: 22
Gerrit-Owner: Nicolas Reinecke
nr@das-labor.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nicolas Reinecke
nr@das-labor.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eloy Degen
Gerrit-CC: Matt Parnell
mparnell@gmail.com
Gerrit-CC: Okashi Odayakana
okashi@okashi.me
Gerrit-CC: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Comment-Date: Tue, 08 Oct 2019 14:59:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment