Attention is currently required from: Anjaneya "Reddy" Chagam, Patrick Rudolph, Jonathan Zhang, Johnny Lin, Angel Pons, Morgan Jang.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50237 )
Change subject: mb/ocp/deltalake: Implement skipping TXT lockdown via VPD
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/ocp/deltalake/ramstage.c:
https://review.coreboot.org/c/coreboot/+/50237/comment/6ad1ff1c_123ddcd9
PS1, Line 368: static bool fetched_vpd = 0;
Do you really need to cache this? The function is only called once
The follow-up patch does ;)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50237
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5daf96bdda9c36054c410b07b08bcd3482d777c
Gerrit-Change-Number: 50237
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Comment-Date: Wed, 03 Feb 2021 01:20:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment