HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44738 )
Change subject: soc/ti/am335x/header.c: Add missing include ......................................................................
soc/ti/am335x/header.c: Add missing include
Use of 'offsetof' needs stddef.
Change-Id: Ie250b20f464909649b2bd038dbb757d5df637486 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/ti/am335x/header.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/44738/1
diff --git a/src/soc/ti/am335x/header.c b/src/soc/ti/am335x/header.c index 9edfdd0..9ed9937 100644 --- a/src/soc/ti/am335x/header.c +++ b/src/soc/ti/am335x/header.c @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
+#include <stddef.h> #include <stdint.h> #include <symbols.h>
Attention is currently required from: HAOUAS Elyes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44738 )
Change subject: soc/ti/am335x/header.c: Add missing include ......................................................................
Patch Set 6:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/44738/comment/60607c93_2485486f PS6, Line 9: Use of 'offsetof' needs stddef. Strictly speaking, it needs `commonlib/bsd/helpers.h`
Attention is currently required from: Angel Pons. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44738 )
Change subject: soc/ti/am335x/header.c: Add missing include ......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/44738/comment/86ba90b5_011fbdd4 PS6, Line 9: Use of 'offsetof' needs stddef.
Strictly speaking, it needs `commonlib/bsd/helpers. […]
it should be in stddef ...
Attention is currently required from: Angel Pons. Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44738
to look at the new patch set (#8).
Change subject: soc/ti/am335x/header.c: Add missing include ......................................................................
soc/ti/am335x/header.c: Add missing include
Use of 'offsetof' needs <commonlib/bsd/helpers.h>.
Change-Id: Ie250b20f464909649b2bd038dbb757d5df637486 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/ti/am335x/header.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/44738/8
Attention is currently required from: HAOUAS Elyes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44738 )
Change subject: soc/ti/am335x/header.c: Add missing include ......................................................................
Patch Set 8: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/44738/comment/b6f6bb4d_15079288 PS6, Line 9: Use of 'offsetof' needs stddef.
it should be in stddef ...
stddef.h also includes commonlib/bsd/helpers.h, but we only need offsetof
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44738 )
Change subject: soc/ti/am335x/header.c: Add missing include ......................................................................
soc/ti/am335x/header.c: Add missing include
Use of 'offsetof' needs <commonlib/bsd/helpers.h>.
Change-Id: Ie250b20f464909649b2bd038dbb757d5df637486 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/44738 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/ti/am335x/header.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/soc/ti/am335x/header.c b/src/soc/ti/am335x/header.c index c0a7589..66d7c20 100644 --- a/src/soc/ti/am335x/header.c +++ b/src/soc/ti/am335x/header.c @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
+#include <commonlib/bsd/helpers.h> #include <stdint.h> #include <symbols.h>
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)