Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/64124 )
Change subject: mb/google/guybrush/devicetree: use defines for ComboPhyStaticConfig ......................................................................
mb/google/guybrush/devicetree: use defines for ComboPhyStaticConfig
Use the existing definitions from FspUsb.h instead of magic values for the ComboPhyStaticConfig settings in the mainboard's devicetree.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I2707d017909b7516e5d8711c8f4e2914165ed10d --- M src/mainboard/google/guybrush/variants/baseboard/devicetree.cb M src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb 2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/64124/1
diff --git a/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb b/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb index 696e16d..0b69af9 100644 --- a/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb @@ -217,8 +217,8 @@ .tx_vboost_lvl_en=1, .tx_vboost_lvl=5, }, - .ComboPhyStaticConfig[0] = 0, - .ComboPhyStaticConfig[1] = 0, + .ComboPhyStaticConfig[0] = USB_COMBO_PHY_MODE_USB_C, + .ComboPhyStaticConfig[1] = USB_COMBO_PHY_MODE_USB_C, .BatteryChargerEnable = 0, .PhyP3CpmP4Support = 0, }" diff --git a/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb b/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb index 85581d2..8270b14 100644 --- a/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb +++ b/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb @@ -154,8 +154,8 @@ .tx_vboost_lvl_en=1, .tx_vboost_lvl=5, }, - .ComboPhyStaticConfig[0] = 0, - .ComboPhyStaticConfig[1] = 0, + .ComboPhyStaticConfig[0] = USB_COMBO_PHY_MODE_USB_C, + .ComboPhyStaticConfig[1] = USB_COMBO_PHY_MODE_USB_C, .BatteryChargerEnable = 0, .PhyP3CpmP4Support = 0, }"