Attention is currently required from: Paul Menzel.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63178 )
Change subject: mb/google/brya: Consistently put void before __weak attribute
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63178/comment/77ca355a_a60e6626
PS2, Line 7: mb/google/brya: Make __weak usage consistent
At least I had to look at the diff to understand, what is meant by this. […]
Done
Patchset:
PS2:
I think Tim is just making sure the usage is consistent within the same file. […]
Right, the commit is prefixed with mb/google/brya, so I grepped for __weak in that directory and made what I found consistent.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63178
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic59cccdf0fb88fc71a440170ee40b73dd8736a33
Gerrit-Change-Number: 63178
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 03 May 2022 15:04:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Gerrit-MessageType: comment