Attention is currently required from: Raul Rangel, Lee Leahy, Huang Jin, Kyösti Mälkki, Patrick Rudolph, Aaron Durbin.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54298 )
Change subject: arch/x86/postcar: Use a separate stack for C execution
......................................................................
Patch Set 6:
(1 comment)
File src/arch/x86/exit_car.S:
https://review.coreboot.org/c/coreboot/+/54298/comment/d2cba8b4_0b715984
PS6, Line 108: mov post_car_stack_top, %esp
Can we use `_estack` now?
Not yet (done at line 189). It's still weirdly called post_car_stack_top here but that's only because that's how the MTRR setup is passed to postcar so it's just a bad name now. I the next CL this is dropped so I didn't bother renaming it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54298
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67cbc988051036b1a0519cec9ed614acede31fd7
Gerrit-Change-Number: 54298
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Huang Jin
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Attention: Huang Jin
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Thu, 31 Mar 2022 17:20:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment