Attention is currently required from: Ravi kumar, Paul Menzel, mturney mturney, Julius Werner.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59195 )
Change subject: soc/qualcomm/common: Add dram information to CBMEM table
......................................................................
Patch Set 21:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59195/comment/faf629c9_c1c6b920
PS21, Line 9: BUG=b:182963902,177917361
BUG=b:182963902,b:177917361
https://review.coreboot.org/c/coreboot/+/59195/comment/67ef23f5_c03c4f6f
PS21, Line 10: developement
development
File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/59195/comment/f5c893f3_81a35fe1
PS5, Line 174: mem_chip_info
Okay, so you're ignoring the pointer coreboot passes in the table, and having QcLib overwrite it wit […]
Was the plan to explicitly pass NULL,0 as Julius requested? I also don't see any comments explaining how a NULL pointer is intentionally being passed in and why. Did you guys also update the qclib-interface.md doc as requested?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59195
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f1dd05ee224bf8284661c0afaa01d0a9d71daa7
Gerrit-Change-Number: 59195
Gerrit-PatchSet: 21
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: mturney mturney
quic_mturney@quicinc.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: mturney mturney
quic_mturney@quicinc.com
Gerrit-Comment-Date: Tue, 01 Feb 2022 23:15:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: mturney mturney
quic_mturney@quicinc.com
Gerrit-MessageType: comment