Attention is currently required from: Patrick Rudolph, Christian Walter, Angel Pons, Lean Sheng Tan, David.Milosevic@9elements.com.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68137 )
Change subject: [WIP] mb/prodrive/atlas: Populate smbios table with VPD from ECs EMI ......................................................................
Patch Set 6:
(6 comments)
File src/mainboard/prodrive/atlas/emi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159865): https://review.coreboot.org/c/coreboot/+/68137/comment/1f2d9ea0_7b767265 PS6, Line 51: switch (access) { switch and case should be at the same indent
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159865): https://review.coreboot.org/c/coreboot/+/68137/comment/5d93655a_06d00df9 PS6, Line 89: switch (access) { switch and case should be at the same indent
File src/mainboard/prodrive/atlas/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159865): https://review.coreboot.org/c/coreboot/+/68137/comment/ac9d411b_9540d719 PS6, Line 14: static const char* get_smbios_part_number(void); "foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159865): https://review.coreboot.org/c/coreboot/+/68137/comment/a0451ecc_9ed381b2 PS6, Line 41: static const char* get_smbios_part_number(void) "foo* bar" should be "foo *bar"
File src/mainboard/prodrive/atlas/smbios.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159865): https://review.coreboot.org/c/coreboot/+/68137/comment/cf8805c4_14f05b4b PS6, Line 8: const char* smbios_mainboard_serial_number(void) "foo* bar" should be "foo *bar"
File src/mainboard/prodrive/atlas/vpd.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159865): https://review.coreboot.org/c/coreboot/+/68137/comment/492a1b51_74ebc866 PS6, Line 34: switch (vpd) { switch and case should be at the same indent