build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52475 )
Change subject: mb/hp: Add Compal LA-A992P ......................................................................
Patch Set 14:
(17 comments)
File src/mainboard/hp/hp_15_notebook_pc/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/d18623d2_9d117175 PS14, Line 15: /* 00 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x40, 0x00, 0x00, 0x00, 0xff, 0x04, 0x00, 0x00, 0x12, 0x01, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/10a0ff12_551ca5ed PS14, Line 16: /* 10 */ 0x01, 0x1b, 0x33, 0x1b, 0x00, 0x00, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0x00, 0x04, 0x03, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/d01f6566_1bc966f3 PS14, Line 17: /* 20 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/730f943f_75c405de PS14, Line 18: /* 30 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/e7cd6b72_88f4696a PS14, Line 19: /* 40 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/38df34d6_7396d1e4 PS14, Line 20: /* 50 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/d6182ce7_6e3138a3 PS14, Line 21: /* 60 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/f5a08d65_1e1f782f PS14, Line 22: /* 70 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/40eab0e8_e2837aa4 PS14, Line 23: /* 80 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/11a5065b_3c207e57 PS14, Line 24: /* 90 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/96ef813d_68c2f1c1 PS14, Line 25: /* a0 */ 0x00, 0x04, 0x00, 0x86, 0xc1, 0x00, 0x00, 0x61, 0x63, 0x00, 0x00, 0x08, 0x64, 0x1a, 0x00, 0xf0, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/6072cc90_e6054680 PS14, Line 26: /* b0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x09, 0x00, 0x00, 0x32, 0x02, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/92d1dd3a_2fdfb86d PS14, Line 27: /* c0 */ 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/9c18ac71_427d9b32 PS14, Line 28: /* d0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/1026a7c3_963c451e PS14, Line 29: /* e0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/23199dbc_0edb0d08 PS14, Line 30: /* f0 */ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120890): https://review.coreboot.org/c/coreboot/+/52475/comment/e275f2f1_aab708c4 PS14, Line 35: ec_write (i, dmp[i]); space prohibited between function name and open parenthesis '('