Change in coreboot[master]: mb/google/brya/variants/taeko: Add initial fw config for taeko

[Joey Peng (Code Review)]

Attention is currently required from: Tim Wawrzynczak, YH Lin.
Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57332 )

Change subject: mb/google/brya/variants/taeko: Add initial fw config for taeko
......................................................................

Patch Set 9:

(5 comments)

This change is ready for review.

File src/mainboard/google/brya/variants/taeko/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/57332/comment/3ce19217_3f2e999e 
PS7, Line 1: fw_config
           : 	field KB_BL 4 4
           : 		option KB_BL_ABSENT	0
           : 		option KB_BL_PRESENT	1
           : 	end
           : 	field AUDIO 5 7
           : 		option AUDIO_UNKNOWN	0
           : 		option MAX98357_ALC5682I_I2S	1
           : 	end
           : 	field BOOT_DEVICE_EMMC 12 12
           : 		option BOOT_EMMC_DISABLED	0
           : 		option BOOT_EMMC_ENABLED	1
           : 	end
           : 	field BOOT_DEVICE_NVME 13 13
           : 		option BOOT_NVME_DISABLED	0
           : 		option BOOT_NVME_ENABLED	1
           : 	end
           : end
> From config.star, I think the fw_config section should look like this: […]

Done

https://review.coreboot.org/c/coreboot/+/57332/comment/bf1e9e4d_4deaf4c8 
PS7, Line 172: 			end
> Looks like you'll also need a soundwire FW_CONFIG option for AUDIO

We confirmed with EE team that we won't use soundwire. We will remove this part.

https://review.coreboot.org/c/coreboot/+/57332/comment/33e2e4ac_8bca490c 
PS7, Line 193:
> `probe DB_SD DB_SD_PRESENT`

Done

https://review.coreboot.org/c/coreboot/+/57332/comment/528ba840_e018a45f 
PS7, Line 247: chip drivers/usb/acpi
             : 						register "desc" = ""USB3 Type-C Port C1 (DB)""
             : 						register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
             : 						register "group" = "ACPI_PLD_GROUP(3, 1)"
             : 						device ref tcss_usb3_port3 on end
> You need a FW_CONFIG DB_USB for this one as well (is it the same one that has the Type-A port ?)

This one is for DB_USB3_NO_A.

https://review.coreboot.org/c/coreboot/+/57332/comment/eb670ee6_71550472 
PS7, Line 294:
> This would seem to depend on a probe for options that don't exist yet... […]

This one is for MLB Type-A configuration, not for DB.