Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37390 )
Change subject: superio/aspeed: Remove unused aspeed include path ......................................................................
superio/aspeed: Remove unused aspeed include path
Working on some other code, I noticed that superio/aspeed was added as an include path even though I wasn't using it. I investigated and found that NOTHING is using it. The files in the aspeed directory all reference files in their own directory.
The supermicro x11-lga1151-series boards are the only ones using this SIO.
TEST=util/abuild/abuild -t supermicro/x11-lga1151-series
Signed-off-by: Martin Roth martin@coreboot.org Change-Id: I377066451a50452c17c9bfaa0f815f69e039984e --- M src/superio/aspeed/Makefile.inc 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/37390/1
diff --git a/src/superio/aspeed/Makefile.inc b/src/superio/aspeed/Makefile.inc index 6d0cc26..b9494fa 100644 --- a/src/superio/aspeed/Makefile.inc +++ b/src/superio/aspeed/Makefile.inc @@ -20,5 +20,3 @@
subdirs-y += ast2400 subdirs-y += common - -CPPFLAGS_common += -Isrc/superio/aspeed
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37390 )
Change subject: superio/aspeed: Remove unused aspeed include path ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37390 )
Change subject: superio/aspeed: Remove unused aspeed include path ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37390 )
Change subject: superio/aspeed: Remove unused aspeed include path ......................................................................
superio/aspeed: Remove unused aspeed include path
Working on some other code, I noticed that superio/aspeed was added as an include path even though I wasn't using it. I investigated and found that NOTHING is using it. The files in the aspeed directory all reference files in their own directory.
The supermicro x11-lga1151-series boards are the only ones using this SIO.
TEST=util/abuild/abuild -t supermicro/x11-lga1151-series
Signed-off-by: Martin Roth martin@coreboot.org Change-Id: I377066451a50452c17c9bfaa0f815f69e039984e Reviewed-on: https://review.coreboot.org/c/coreboot/+/37390 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/superio/aspeed/Makefile.inc 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/superio/aspeed/Makefile.inc b/src/superio/aspeed/Makefile.inc index 6d0cc26..b9494fa 100644 --- a/src/superio/aspeed/Makefile.inc +++ b/src/superio/aspeed/Makefile.inc @@ -20,5 +20,3 @@
subdirs-y += ast2400 subdirs-y += common - -CPPFLAGS_common += -Isrc/superio/aspeed
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Martin Roth (Code Review)
-
Patrick Georgi (Code Review)