Change in coreboot[master]: acpi/device: Add ability to generate proper _STA for PowerResource - coreboot-gerrit

1 Jun 2021


      Attention is currently required from: Lance Zhao, Raul Rangel, Furquan Shaikh.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55027 )
Change subject: acpi/device: Add ability to generate proper _STA for PowerResource
......................................................................
Patch Set 2:
(1 comment)
File src/acpi/device.c:
https://review.coreboot.org/c/coreboot/+/55027/comment/383aeb0f_dc02f5e8 
PS2, Line 649: 0x1
Since a PowerResources uses the return value of _STA differently than a Device, how about adding new #defines for these?
e.g.
```
#define ACPI_POWER_RESOURCE_STATUS_ON   1
#define ACPI_POWER_RESOURCE_STATUS_OFF  0
```
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/55027
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I91410556db002c620fd9aaa99981457808da93a5
Gerrit-Change-Number: 55027
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Comment-Date: Tue, 01 Jun 2021 20:15:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment