Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Fei Yan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82076?usp=email )
Change subject: soc/mediatek/mt8188: devapc: set devapc permission for MFG ......................................................................
Patch Set 4: Code-Review+1
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82076/comment/2706c4e9_6774de19 : PS2, Line 7: UPSTREAM
Remove `UPSTREAM:`.
Done
https://review.coreboot.org/c/coreboot/+/82076/comment/84205b63_c82dfe74 : PS2, Line 9: Set MFG to domain 6.
No need to start a new line for each sentence.
Done
https://review.coreboot.org/c/coreboot/+/82076/comment/cf0dc02b_7a63b20a : PS2, Line 14: So that only AP in secure mode can access MFG_S_S-2 and MFG_S_S-5
Missing `.` at the end.
Done
https://review.coreboot.org/c/coreboot/+/82076/comment/fea6bab4_86c00134 : PS2, Line 13: . : So
, so
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/82076/comment/a2a68f36_6975a458 : PS3, Line 9: Set MFG to domain 6. : Set MFG remap in infra and sub infra, so that MFG can switch to protect mode by MFG register. : Set MFG slave MFG_S_S-2 and MFG_S_S-5 permission from NO_PROTECTION to SEC_RW_ONLY for domain 0, : so that only AP in secure mode can access MFG_S_S-2 and MFG_S_S-5.
72 characters per line for the commit message.
Done