Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Zhuohao Lee, Alan Huang.
Rory Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61267 )
Change subject: drivers/net/r8168: Add ASPM control mechanism
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61267/comment/f3fba696_975570f8
PS1, Line 13:
Is that already done for other devices? […]
We're not sure if it's necessary for other devices, so we make it optional.
Combined with https://review.coreboot.org/c/coreboot/+/61268.
We can enable it in device tree.
File src/drivers/net/r8168.c:
https://review.coreboot.org/c/coreboot/+/61267/comment/cb0b1675_57f089e4
PS1, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
Unintentional.
Ack
https://review.coreboot.org/c/coreboot/+/61267/comment/a4939a3f_b68ec519
PS1, Line 30: #define CMD_REG_ASPM 0xb0
Move to the end?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61267
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I944dbf04d3ca19df4de224540bee538bff4d1f12
Gerrit-Change-Number: 61267
Gerrit-PatchSet: 2
Gerrit-Owner: Rory Liu
rory.liu@quanta.corp-partner.google.com
Gerrit-Reviewer: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 24 Jan 2022 01:54:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment