Attention is currently required from: Terry Chen, Malik Hsu, Tim Wawrzynczak, EricR Lai, Casper Chang.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62465 )
Change subject: mb/google/brya/var/primus{4es}: modify GPP_B3 as unlocked
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
Patchset:
PS3:
Thanks EricR and Subrata's comment. I set GPP_B3 to low in early table as BH799BB's power on sequence requested.
Thanks Casper, please update the commit msg to reflect the same as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62465
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd5f9d59d33cd1c5ebe0454ab3aa4c5641c16ff6
Gerrit-Change-Number: 62465
Gerrit-PatchSet: 4
Gerrit-Owner: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Attention: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Attention: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-Comment-Date: Tue, 01 Mar 2022 08:42:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Comment-In-Reply-To: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-MessageType: comment