Attention is currently required from: Joel Linn, Matt DeVillier, Nicholas Chin.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81368?usp=email )
Change subject: mb/hp: Add Pro 3500 series (Sandy/Ivy Bridge) ......................................................................
Patch Set 5: Code-Review+2
(6 comments)
Patchset:
PS5: A few small cleanups. Otherwise looks good.
File src/mainboard/hp/pro_3500_series/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/81368/comment/19125743_feabcdd2 : PS5, Line 11: device ref host_bridge on end Enabled in chipset devicetree
https://review.coreboot.org/c/coreboot/+/81368/comment/adfaa846_cc0744e5 : PS5, Line 16: register "docking_supported" = "0" Doesn't have any effect, set to 0 anyway.
https://review.coreboot.org/c/coreboot/+/81368/comment/38add2e1_dc5df95b : PS5, Line 27: device ref mei1 on end Enabled in chipset devicetree
https://review.coreboot.org/c/coreboot/+/81368/comment/0d3c6369_4f8d2d62 : PS5, Line 36: # LPC bridge Remove superfluous comment
https://review.coreboot.org/c/coreboot/+/81368/comment/07738d1c_fff47e10 : PS5, Line 96: device ref smbus on end Enabled in chipset devicetree