Attention is currently required from: Angel Pons, Dinesh Gehlot.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/82146?usp=email )
Change subject: gma: Support ADL-P CDClk clock crawl ......................................................................
Patch Set 4:
(1 comment)
File common/tigerlake/hw-gfx-gma-power_and_clocks.adb:
https://review.coreboot.org/c/libgfxinit/+/82146/comment/6eacb1ac_cb79e75c : PS2, Line 564: if Config.Has_CDClk_PLL_Crawl then : Registers.Unset_And_Set_Mask : (Register => Registers.MBUS_CTL, : Mask_Unset => MBUS_HASHING_MODE_MASK or : MBUS_JOIN or : MBUS_JOIN_PIPE_SELECT_MASK, : Mask_Set => MBUS_HASHING_MODE_1x4 or : MBUS_JOIN or : MBUS_JOIN_PIPE_SELECT_NONE); : : Registers.Unset_And_Set_Mask : (Register => Registers.DBUF_CTL_S0, : Mask_Unset => DBUF_CTL_MIN_TRACKER_STATE_SERVICE_MASK, : Mask_Set => : Shift_Left (3, DBUF_CTL_MIN_TRACKER_STATE_SERVICE_SHIFT)); : else : Registers.Unset_And_Set_Mask : (Register => Registers.DBUF_CTL_S0, : Mask_Unset => DBUF_CTL_TRACKER_STATE_SERVICE_MASK, : Mask_Set => Shift_Left (8, DBUF_CTL_TRACKER_STATE_SERVICE_SHIFT)); : end if;
The Mask and shift values are also different. if we want to move "update `Registers. […]
Ack