Change in ...coreboot[master]: drivers/intel/wifi: Add support for Harrison Peak (HrP) 9560 module

[Subrata Banik (Code Review)]

Hello Wonkyu Kim,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/31475

to review the following change.

Change subject: drivers/intel/wifi: Add support for Harrison Peak (HrP) 9560 module
......................................................................

drivers/intel/wifi: Add support for Harrison Peak (HrP) 9560 module

Add HrP 9560 module device ID (0x02F0) into device/pci_ids.h file.

TEST=HrP module is getting detected during PCI enumeration

Change-Id: Id0a8a7a8cf7c665bd49f27b1c50d41d26a3274ce
Signed-off-by: Subrata Banik 
Signed-off-by: Wonkyu Kim 
---
M src/drivers/intel/wifi/wifi.c
M src/include/device/pci_ids.h
2 files changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/31475/1

diff --git a/src/drivers/intel/wifi/wifi.c b/src/drivers/intel/wifi/wifi.c
index cd512ea..416b04b 100644
--- a/src/drivers/intel/wifi/wifi.c
+++ b/src/drivers/intel/wifi/wifi.c
@@ -350,6 +350,7 @@
    /* Harrison Peak */
    PCI_DEVICE_ID_HrP_9560_SERIES_1_WIFI,
    PCI_DEVICE_ID_HrP_9560_SERIES_2_WIFI,
+	PCI_DEVICE_ID_HrP_9560_SERIES_3_WIFI,
    0
 };

diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h
index 751cca0..9c5ffb3 100644
--- a/src/include/device/pci_ids.h
+++ b/src/include/device/pci_ids.h
@@ -3136,6 +3136,7 @@
 #define PCI_DEVICE_ID_TP_9260_SERIES_WIFI	0x2526
 #define PCI_DEVICE_ID_HrP_9560_SERIES_1_WIFI	0x34f0
 #define PCI_DEVICE_ID_HrP_9560_SERIES_2_WIFI	0xa0f0
+#define PCI_DEVICE_ID_HrP_9560_SERIES_3_WIFI	0x02f0

#define PCI_VENDOR_ID_COMPUTONE		0x8e0e
 #define PCI_DEVICE_ID_COMPUTONE_IP2EX	0x0291

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31475 )

Change subject: drivers/intel/wifi: Add support for Harrison Peak (HrP) 9560 module
......................................................................

Patch Set 1: Code-Review+1

[Wonkyu Kim (Code Review)]

Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31475 )

Change subject: drivers/intel/wifi: Add support for Harrison Peak (HrP) 9560 module
......................................................................

Patch Set 1: Code-Review+1

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31475 )

Change subject: drivers/intel/wifi: Add support for Harrison Peak (HrP) 9560 module
......................................................................

Patch Set 1: Code-Review+2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31475 )

Change subject: drivers/intel/wifi: Add support for Harrison Peak (HrP) 9560 module
......................................................................

Patch Set 1: Code-Review+2

[Subrata Banik (Code Review)]

Subrata Banik has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31475 )

Change subject: drivers/intel/wifi: Add support for Harrison Peak (HrP) 9560 module
......................................................................

drivers/intel/wifi: Add support for Harrison Peak (HrP) 9560 module

Add HrP 9560 module device ID (0x02F0) into device/pci_ids.h file.

TEST=HrP module is getting detected during PCI enumeration

Change-Id: Id0a8a7a8cf7c665bd49f27b1c50d41d26a3274ce
Signed-off-by: Subrata Banik 
Signed-off-by: Wonkyu Kim 
Reviewed-on: https://review.coreboot.org/c/31475
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Menzel 
Reviewed-by: Duncan Laurie 
Reviewed-by: Furquan Shaikh 
---
M src/drivers/intel/wifi/wifi.c
M src/include/device/pci_ids.h
2 files changed, 2 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Duncan Laurie: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve
  Furquan Shaikh: Looks good to me, approved
  Wonkyu Kim: Looks good to me, but someone else must approve

diff --git a/src/drivers/intel/wifi/wifi.c b/src/drivers/intel/wifi/wifi.c
index cd512ea..416b04b 100644
--- a/src/drivers/intel/wifi/wifi.c
+++ b/src/drivers/intel/wifi/wifi.c
@@ -350,6 +350,7 @@
    /* Harrison Peak */
    PCI_DEVICE_ID_HrP_9560_SERIES_1_WIFI,
    PCI_DEVICE_ID_HrP_9560_SERIES_2_WIFI,
+	PCI_DEVICE_ID_HrP_9560_SERIES_3_WIFI,
    0
 };

diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h
index 0030961..2d19194 100644
--- a/src/include/device/pci_ids.h
+++ b/src/include/device/pci_ids.h
@@ -3137,6 +3137,7 @@
 #define PCI_DEVICE_ID_TP_9260_SERIES_WIFI	0x2526
 #define PCI_DEVICE_ID_HrP_9560_SERIES_1_WIFI	0x34f0
 #define PCI_DEVICE_ID_HrP_9560_SERIES_2_WIFI	0xa0f0
+#define PCI_DEVICE_ID_HrP_9560_SERIES_3_WIFI	0x02f0

#define PCI_VENDOR_ID_COMPUTONE		0x8e0e
 #define PCI_DEVICE_ID_COMPUTONE_IP2EX	0x0291