Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45905 )
Change subject: drivers/intel/fsp2_0: Integrate FirmwareVersionInfo.h ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45905/2/src/drivers/intel/fsp2_0/Kc... File src/drivers/intel/fsp2_0/Kconfig.debug_blob:
https://review.coreboot.org/c/coreboot/+/45905/2/src/drivers/intel/fsp2_0/Kc... PS2, Line 42: bool "Display Firmware Ingredient Version Information"
both help text is same ?
Done
https://review.coreboot.org/c/coreboot/+/45905/2/src/drivers/intel/fsp2_0/ha... File src/drivers/intel/fsp2_0/hand_off_block.c:
https://review.coreboot.org/c/coreboot/+/45905/2/src/drivers/intel/fsp2_0/ha... PS2, Line 262:
will upload new patch set with optimization
I have updated the patch please let me know you comments.
https://review.coreboot.org/c/coreboot/+/45905/2/src/drivers/intel/fsp2_0/in... File src/drivers/intel/fsp2_0/include/fsp/soc_binding.h:
https://review.coreboot.org/c/coreboot/+/45905/2/src/drivers/intel/fsp2_0/in... PS2, Line 37:
remove one empty line
Done
-
Ronak Kanabar (Code Review)