Wayne3 Wang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49197 )
Change subject: Drobit: Audio no sound ......................................................................
Drobit: Audio no sound
Add SOC_INTEL_CSE_LITE_SKU setting for drobit
BUG=b:176536593 BRANCH=none TEST=emerge-volteer coreboot
Change-Id: I69962a5b7c7c464280b35c834f7ee1c9b77db6fd --- M 3rdparty/amd_blobs M 3rdparty/blobs M 3rdparty/intel-microcode M 3rdparty/qc_blobs M src/mainboard/google/volteer/Kconfig.name 5 files changed, 5 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/49197/1
diff --git a/3rdparty/amd_blobs b/3rdparty/amd_blobs index 3e4a2e5..539d31a 160000 --- a/3rdparty/amd_blobs +++ b/3rdparty/amd_blobs @@ -1 +1 @@ -Subproject commit 3e4a2e530f6f6dab7e9dc4af3feff9bdb2073b18 +Subproject commit 539d31ab9ea89084fa5edf7cc9ac3122786d5454 diff --git a/3rdparty/blobs b/3rdparty/blobs index a59fb6e..9082f75 160000 --- a/3rdparty/blobs +++ b/3rdparty/blobs @@ -1 +1 @@ -Subproject commit a59fb6e3892f0629d43769a07ee7f1048a0ae1f8 +Subproject commit 9082f7582d7d978ab29fc542f58de163ae065d07 diff --git a/3rdparty/intel-microcode b/3rdparty/intel-microcode index 0e4288f..ee319ae 160000 --- a/3rdparty/intel-microcode +++ b/3rdparty/intel-microcode @@ -1 +1 @@ -Subproject commit 0e4288f81f806620c65f70ee2bcf94b69d574096 +Subproject commit ee319ae7bc59e88b60142f40a9ec1b46656de4db diff --git a/3rdparty/qc_blobs b/3rdparty/qc_blobs index 6b7fe49..45b6c86 160000 --- a/3rdparty/qc_blobs +++ b/3rdparty/qc_blobs @@ -1 +1 @@ -Subproject commit 6b7fe498eb782b8f9758f28dd53bb0697be0d0b0 +Subproject commit 45b6c8618b729c1998606d605fc854f6ea7a5772 diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name index 8777994..9eaeb72 100644 --- a/src/mainboard/google/volteer/Kconfig.name +++ b/src/mainboard/google/volteer/Kconfig.name @@ -96,6 +96,7 @@ config BOARD_GOOGLE_DROBIT bool "-> Drobit" select BOARD_GOOGLE_BASEBOARD_VOLTEER + select SOC_INTEL_CSE_LITE_SKU
config BOARD_GOOGLE_COPANO bool "-> Copano"
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49197
to look at the new patch set (#2).
Change subject: Drobit: Audio no sound ......................................................................
Drobit: Audio no sound
Add SOC_INTEL_CSE_LITE_SKU setting for drobit
BUG=b:176536593 BRANCH=none TEST=emerge-volteer coreboot
Change-Id: I69962a5b7c7c464280b35c834f7ee1c9b77db6fd --- M src/mainboard/google/volteer/Kconfig.name 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/49197/2
Wayne3 Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49197 )
Change subject: Drobit: Audio no sound ......................................................................
Patch Set 2: Code-Review+1
Hello build bot (Jenkins), Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49197
to look at the new patch set (#3).
Change subject: Drobit: Audio no sound ......................................................................
Drobit: Audio no sound
Add SOC_INTEL_CSE_LITE_SKU setting for drobit
BUG=b:176536593 BRANCH=none TEST=emerge-volteer coreboot
Signed-off-by: Wayne3_Wang wayne3_wang@pegatron.corp-partner.google.com Change-Id: I69962a5b7c7c464280b35c834f7ee1c9b77db6fd --- M src/mainboard/google/volteer/Kconfig.name 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/49197/3
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49197 )
Change subject: Drobit: Audio no sound ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/49197/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/49197/3//COMMIT_MSG@12 PS3, Line 12: BRANCH=none BRANCH=firmware-volteer-13672.B
Hello build bot (Jenkins), Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49197
to look at the new patch set (#4).
Change subject: Drobit: Audio no sound ......................................................................
Drobit: Audio no sound
Add SOC_INTEL_CSE_LITE_SKU setting for drobit
BUG=b:176536593 BRANCH=firmware-volteer-13672.B TEST=emerge-volteer coreboot
Signed-off-by: Wayne3_Wang wayne3_wang@pegatron.corp-partner.google.com Change-Id: I69962a5b7c7c464280b35c834f7ee1c9b77db6fd --- M src/mainboard/google/volteer/Kconfig.name 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/49197/4
Wayne3 Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49197 )
Change subject: Drobit: Audio no sound ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/49197/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/49197/3//COMMIT_MSG@12 PS3, Line 12: BRANCH=none
BRANCH=firmware-volteer-13672. […]
Done
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49197 )
Change subject: Drobit: Audio no sound ......................................................................
Patch Set 4: Code-Review+1
Attention is currently required from: Wayne3 Wang, Nick Vaccaro. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49197 )
Change subject: Drobit: Audio no sound ......................................................................
Patch Set 4: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49197/comment/ad4982ca_efd1df7f PS4, Line 7: Drobit: Audio no sound Suggest: `mb/google/volteer: Add CSE Lite SKU support to Drobit`
https://review.coreboot.org/c/coreboot/+/49197/comment/7c3a67f3_f359faa8 PS4, Line 9: Add SOC_INTEL_CSE_LITE_SKU setting for drobit This will allow CSE RW FW updates and also fixes the problem where no sound is emitted from the speakers.
Attention is currently required from: Wayne3 Wang, Nick Vaccaro. Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49197
to look at the new patch set (#5).
Change subject: mb/google/volteer: Add CSE Lite SKU support to Drobit ......................................................................
mb/google/volteer: Add CSE Lite SKU support to Drobit
This will allow CSE RW FW updates and also fixes the problem where no sound is emitted from the speakers.
BUG=b:176536593 BRANCH=firmware-volteer-13672.B TEST=emerge-volteer coreboot
Signed-off-by: Wayne3_Wang wayne3_wang@pegatron.corp-partner.google.com Change-Id: I69962a5b7c7c464280b35c834f7ee1c9b77db6fd --- M src/mainboard/google/volteer/Kconfig.name 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/49197/5
Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro. Wayne3 Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49197 )
Change subject: mb/google/volteer: Add CSE Lite SKU support to Drobit ......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49197/comment/b8ed8e2f_11e9c7f9 PS4, Line 7: Drobit: Audio no sound
Suggest: […]
Done
https://review.coreboot.org/c/coreboot/+/49197/comment/fc33bd41_c2739989 PS4, Line 9: Add SOC_INTEL_CSE_LITE_SKU setting for drobit
This will allow CSE RW FW updates and also fixes the problem where no sound is emitted from the spea […]
Done
Attention is currently required from: Wayne3 Wang, Nick Vaccaro. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49197 )
Change subject: mb/google/volteer: Add CSE Lite SKU support to Drobit ......................................................................
Patch Set 5: Code-Review+2
Attention is currently required from: Wayne3 Wang, Nick Vaccaro. Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49197 )
Change subject: mb/google/volteer: Add CSE Lite SKU support to Drobit ......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5: Could we merge this patch?
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49197 )
Change subject: mb/google/volteer: Add CSE Lite SKU support to Drobit ......................................................................
mb/google/volteer: Add CSE Lite SKU support to Drobit
This will allow CSE RW FW updates and also fixes the problem where no sound is emitted from the speakers.
BUG=b:176536593 BRANCH=firmware-volteer-13672.B TEST=emerge-volteer coreboot
Signed-off-by: Wayne3_Wang wayne3_wang@pegatron.corp-partner.google.com Change-Id: I69962a5b7c7c464280b35c834f7ee1c9b77db6fd Reviewed-on: https://review.coreboot.org/c/coreboot/+/49197 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Zhuohao Lee zhuohao@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/Kconfig.name 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Zhuohao Lee: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved Wayne3 Wang: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name index 491669a..bea163d 100644 --- a/src/mainboard/google/volteer/Kconfig.name +++ b/src/mainboard/google/volteer/Kconfig.name @@ -96,6 +96,7 @@ config BOARD_GOOGLE_DROBIT bool "-> Drobit" select BOARD_GOOGLE_BASEBOARD_VOLTEER + select SOC_INTEL_CSE_LITE_SKU
config BOARD_GOOGLE_COPANO bool "-> Copano"
-
Tim Wawrzynczak (Code Review) -
Wayne3 Wang (Code Review)
-
Zhuohao Lee (Code Review)