Attention is currently required from: Arthur Heymans, Michał Kopeć, Michał Żygowski, Patrick Rudolph, Paul Menzel, Sergii Dmytruk.
Krystian Hebel has posted comments on this change by Krystian Hebel. ( https://review.coreboot.org/c/coreboot/+/82558?usp=email )
Change subject: mb/qemu-q35/smihandler.c: add support for SMIs on QEMU ......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
Unfortunately no, not for QEMU. It would still be an exception due to differences mentioned in first comment block in smihandler.c added here. It could be worked around by using different revisions, but then again it would mean that some board specific workarounds have to be placed in the common code.
I tried to bring those commits back, but new SMM handlers were added after those commits that would need to be aligned (AMD PSP communication). Since this wasn't a trivial change and it didn't fix QEMU issues I dropped that idea.
That single commit could be brought back after adding separate save state ops for QEMU, basically this change. On the other hand, we already have cpu/qemu-x86 which would keep the common code relatively clean. It would still need to differentiate between q35 and i440fx, though, as only the former has SMM. If you think this is acceptable, I can bring back that one change, but I won't be able to find the time to update the rest of relation chain, nor have a way of testing it on different platforms.
-
Krystian Hebel (Code Review)