Attention is currently required from: Krystian Hebel, Michał Żygowski, Nico Huber, Piotr Król.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79612?usp=email )
Change subject: mb/pcengines/apu2/mainboard: fix up ECC scrubber configuration
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS8:
hmm, i booted with this patch applied and ran 'setpci -s 0:18.3 0x44.l' and it returned '48b00044', so bit 22 (DramEccEn) in D18F3x44 is 0.
now i have doubts that ecc works for more than just the error injection case
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79612?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifb0cb117bedf900642e93c556a64800e1e52b6ea
Gerrit-Change-Number: 79612
Gerrit-PatchSet: 8
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Comment-Date: Wed, 10 Jan 2024 22:56:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment