[S] Change in coreboot[main]: sb/intel/common/spi: Fix I/O alignment - coreboot-gerrit

10 Oct 2023


      Attention is currently required from: Angel Pons, Felix Held, Kyösti Mälkki, Paul Menzel.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78090?usp=email )
Change subject: sb/intel/common/spi: Fix I/O alignment
......................................................................
Patch Set 3:
(1 comment)
File src/southbridge/intel/common/spi.c:
https://review.coreboot.org/c/coreboot/+/78090/comment/d51480a1_fc207472 :
PS2, Line 96: 	uint8_t *control;
...
i'd suggest to add a comment here that it's an unaligned 16 bit register. […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/78090?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id05b1a080911b71b94ef781c6e26d98165f02f67
Gerrit-Change-Number: 78090
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 10 Oct 2023 06:27:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment