Attention is currently required from: Martin Roth, Michał Kopeć, Stefan Reinauer, Michael Niewöhner.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62497 )
Change subject: payloads/tianocore: Allow custom build parameters for custom builds
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62497/comment/77e41d68_f4aec94d
PS1, Line 9: allowed
what do you mean by allowed?
ALmost all payload are built from hardcoded git repos. Not so long ago TianoCore payload could be built from the upstream repo only, then it changed to upstream vs Mr Chromebox repo and now we can specify own URL for the TianoCore repo. This is first such case I see in coreboot, thus the use of "allowed".
Patchset:
PS1:
This change could be separated from the patch train, so we can get it in faster :)
If it gets +2, we don;t mind rebasing it on master to apply
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62497
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I025459ae94592103b4be0c68b422100b7c649d34
Gerrit-Change-Number: 62497
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Fri, 04 Mar 2022 15:12:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment