Attention is currently required from: Chen Wisley. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57119 )
Change subject: driver/i2c/max98390: add dsm_param_name ......................................................................
Patch Set 16:
(5 comments)
File src/drivers/i2c/max98390/chip.h:
https://review.coreboot.org/c/coreboot/+/57119/comment/769a4280_148b93b3 PS16, Line 16: dsm_param_name `dsm_param_file_name` (then remove the comment)
File src/drivers/i2c/max98390/max98390.c:
https://review.coreboot.org/c/coreboot/+/57119/comment/87eaa388_2954a776 PS16, Line 28: struct acpi_dp *dp = NULL; Why?
https://review.coreboot.org/c/coreboot/+/57119/comment/b2aa2715_15d86b4d PS16, Line 70: config->dsm_param_name); Why also calling it in case `dp == NULL`?
File src/vendorcode/google/chromeos/Kconfig:
https://review.coreboot.org/c/coreboot/+/57119/comment/a540947d_e9b2b89b PS16, Line 73: config CHROMEOS_DSM_PARAM_NAME CHROMEOS_DSM_PARAM_FILE_NAME
https://review.coreboot.org/c/coreboot/+/57119/comment/97886192_7eff91db PS16, Line 78: Management(DSM) Please add a space before (.