Change in coreboot[master]: soc/intel/skylake: Enable CHAP device depending on devicetree

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48323 )

Change subject: soc/intel/skylake: Enable CHAP device depending on devicetree
......................................................................

Patch Set 4:
> Patch Set 4:
> > should probably be done in Kconfig.
>
> I agree, or more configuration options are added to CMOS. But should we get this in first?

Sure, let's get this in and later find a solution for all options. One idea I had was having some priority scheme, like it's done for power-after-fail already, but for all devices, where it makes sense to let the user decide. e.g. CMOS > Kconfig > devicetree or so. That way, there can be a default set in dt and a user can override that at a) build-time and b) runtime
> > Do you actually need that device or do you add it because it's there?
>
> Adding it because it's there, so that options in coreboot work.

ack