Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45951 )
Change subject: soc/intel: deduplicate ACPI timer emulation ......................................................................
Patch Set 18: Code-Review+1
(3 comments)
Should be tested on APL.
https://review.coreboot.org/c/coreboot/+/45951/18//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45951/18//COMMIT_MSG@10 PS18, Line 10: APL Please mention APL differences
https://review.coreboot.org/c/coreboot/+/45951/18/src/soc/intel/alderlake/cp... File src/soc/intel/alderlake/cpu.c:
https://review.coreboot.org/c/coreboot/+/45951/18/src/soc/intel/alderlake/cp... PS18, Line 148: via MSR 0x121 If that's valueable information, you can also put it in the function name.
https://review.coreboot.org/c/coreboot/+/45951/18/src/soc/intel/common/block... File src/soc/intel/common/block/include/intelblocks/cpulib.h:
https://review.coreboot.org/c/coreboot/+/45951/18/src/soc/intel/common/block... PS18, Line 159: /* Enable the emulated ACPI timer to allow disabling the PM ACPI timer (PM1_TMR) */ or in case it's not available (or just skip the reasoning, realize that what is left is already in the name)
-
Nico Huber (Code Review)