Change in ...coreboot[master]: SMBIOS: Fix SPD manufacture ID decoder

[Lijian Zhao (Code Review)]

Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32837

Change subject: SMBIOS: Fix SPD manufacture ID decoder
......................................................................

SMBIOS: Fix SPD manufacture ID decoder

According to latest JEP106 from JEDEC, modify manufacture ID
accordingly.

Signed-off-by: Lijian Zhao 
Change-Id: I10a268a7f3bde405b95bd3a16d5d121be623c7ed
---
M src/arch/x86/smbios.c
1 file changed, 6 insertions(+), 10 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/32837/1

diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c
index 589f4f0..f411bc7 100644
--- a/src/arch/x86/smbios.c
+++ b/src/arch/x86/smbios.c
@@ -140,7 +140,7 @@
    struct smbios_type17 *t)
 {
    switch (mod_id) {
-	case 0x2c80:
+	case 0x9b05:
    	t->manufacturer = smbios_add_string(t->eos,
    					    "Crucial");
    	break;
@@ -148,7 +148,7 @@
    	t->manufacturer = smbios_add_string(t->eos,
    					    "Ramaxel");
    	break;
-	case 0x4f01:
+	case 0x4f80:
    	t->manufacturer = smbios_add_string(t->eos,
    					    "Transcend");
    	break;
@@ -156,10 +156,6 @@
    	t->manufacturer = smbios_add_string(t->eos,
    					    "Kingston");
    	break;
-	case 0x987f:
-		t->manufacturer = smbios_add_string(t->eos,
-						    "Hynix");
-		break;
    case 0x9e02:
    	t->manufacturer = smbios_add_string(t->eos,
    					    "Corsair");
@@ -170,11 +166,11 @@
    	break;
    case 0xad80:
    	t->manufacturer = smbios_add_string(t->eos,
-						    "Hynix/Hyundai");
+						    "SK Hynix");
    	break;
-	case 0xb502:
+	case 0x3486:
    	t->manufacturer = smbios_add_string(t->eos,
-						    "SuperTalent");
+						    "Super Talent");
    	break;
    case 0xcd04:
    	t->manufacturer = smbios_add_string(t->eos,
@@ -188,7 +184,7 @@
    	t->manufacturer = smbios_add_string(t->eos,
    					    "Elpida");
    	break;
-	case 0xff2c:
+	case 0x2c80:
    	t->manufacturer = smbios_add_string(t->eos,
    					    "Micron");
    	break;

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32837 )

Change subject: SMBIOS: Fix SPD manufacture ID decoder
......................................................................

Patch Set 1: Code-Review-1

Please keep compability with old DIMMs

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32837 )

Change subject: SMBIOS: Fix SPD manufacture ID decoder
......................................................................

Patch Set 1:
> Patch Set 1: Code-Review-1
>
> Please keep compability with old DIMMs

I agree, but the manufacture id table itself is not backward compatible, so any suggestion here? Worst case the 0xff2c for Micron is not correct I believe.

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32837 )

Change subject: SMBIOS: Fix SPD manufacture ID decoder
......................................................................

Patch Set 1:

Keep the old values and only add new ones. For duplicated entries use " namea/ nameb"

[Lijian Zhao (Code Review)]

Hello Patrick Rudolph, Bora Guvendik, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32837

to look at the new patch set (#2).

Change subject: SMBIOS: Fix SPD manufacture ID decoder
......................................................................

SMBIOS: Fix SPD manufacture ID decoder

According to latest JEP106 from JEDEC, modify manufacture ID
accordingly.

Signed-off-by: Lijian Zhao 
Change-Id: I10a268a7f3bde405b95bd3a16d5d121be623c7ed
---
M src/arch/x86/smbios.c
1 file changed, 5 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/32837/2

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32837 )

Change subject: SMBIOS: Fix SPD manufacture ID decoder
......................................................................

Patch Set 2:
> Patch Set 1:
>
> Keep the old values and only add new ones. For duplicated entries use " namea/ nameb"

Done.

[Lance Zhao (Code Review)]

Lance Zhao has uploaded a new patch set (#3) to the change originally created by Lijian Zhao. ( https://review.coreboot.org/c/coreboot/+/32837 )

Change subject: SMBIOS: Fix SPD manufacture ID decoder
......................................................................

SMBIOS: Fix SPD manufacture ID decoder

According to latest JEP106 from JEDEC, modify manufacture ID
accordingly.

Signed-off-by: Lijian Zhao 
Change-Id: I10a268a7f3bde405b95bd3a16d5d121be623c7ed
---
M src/arch/x86/smbios.c
1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/32837/3

[Lance Zhao (Code Review)]

Lance Zhao has uploaded a new patch set (#4) to the change originally created by Lijian Zhao. ( https://review.coreboot.org/c/coreboot/+/32837 )

Change subject: SMBIOS: Fix SPD manufacture ID decoder
......................................................................

SMBIOS: Fix SPD manufacture ID decoder

According to JEP106 from JEDEC, fix manufacture ID of Crucial,
Super Talnet and Micron.

Signed-off-by: Lijian Zhao 
Change-Id: I10a268a7f3bde405b95bd3a16d5d121be623c7ed
---
M src/arch/x86/smbios.c
1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/32837/4

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32837 )

Change subject: SMBIOS: Fix SPD manufacture ID decoder
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/32837/4/src/arch/x86/smbios.c 
File src/arch/x86/smbios.c:

https://review.coreboot.org/#/c/32837/4/src/arch/x86/smbios.c@143 
PS4, Line 143: 0x9b05
isn't 0x9b85 ?

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32837 )

Change subject: SMBIOS: Fix SPD manufacture ID decoder
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/32837/4/src/arch/x86/smbios.c 
File src/arch/x86/smbios.c:

https://review.coreboot.org/#/c/32837/4/src/arch/x86/smbios.c@143 
PS4, Line 143: 0x9b05
> isn't 0x9b85 ?

Yes, odd parity shall be 0x9b85

[Lijian Zhao (Code Review)]

Hello Patrick Rudolph, Bora Guvendik, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32837

to look at the new patch set (#5).

Change subject: SMBIOS: Fix SPD manufacture ID decoder
......................................................................

SMBIOS: Fix SPD manufacture ID decoder

According to JEP106 from JEDEC, fix manufacture ID of Crucial,
Super Talnet and Micron.

Signed-off-by: Lijian Zhao 
Change-Id: I10a268a7f3bde405b95bd3a16d5d121be623c7ed
---
M src/arch/x86/smbios.c
1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/32837/5

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32837 )

Change subject: SMBIOS: Fix SPD manufacture ID decoder
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/32837/4/src/arch/x86/smbios.c 
File src/arch/x86/smbios.c:

https://review.coreboot.org/#/c/32837/4/src/arch/x86/smbios.c@143 
PS4, Line 143: 0x9b05
> Yes, odd parity shall be 0x9b85

Done

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32837 )

Change subject: SMBIOS: Fix SPD manufacture ID decoder
......................................................................

Patch Set 5: Code-Review+2

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32837 )

Change subject: SMBIOS: Fix SPD manufacture ID decoder
......................................................................

Patch Set 5: Code-Review+2

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32837 )

Change subject: SMBIOS: Fix SPD manufacture ID decoder
......................................................................

Patch Set 5: Code-Review+2

[Duncan Laurie (Code Review)]

Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32837 )

Change subject: SMBIOS: Fix SPD manufacture ID decoder
......................................................................

SMBIOS: Fix SPD manufacture ID decoder

According to JEP106 from JEDEC, fix manufacture ID of Crucial,
Super Talnet and Micron.

Signed-off-by: Lijian Zhao 
Change-Id: I10a268a7f3bde405b95bd3a16d5d121be623c7ed
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32837
Tested-by: build bot (Jenkins) 
Reviewed-by: HAOUAS Elyes 
Reviewed-by: Duncan Laurie 
Reviewed-by: Patrick Rudolph 
---
M src/arch/x86/smbios.c
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Duncan Laurie: Looks good to me, approved
  HAOUAS Elyes: Looks good to me, approved
  Patrick Rudolph: Looks good to me, approved

diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c
index 589f4f0..90cd674 100644
--- a/src/arch/x86/smbios.c
+++ b/src/arch/x86/smbios.c
@@ -140,7 +140,7 @@
    struct smbios_type17 *t)
 {
    switch (mod_id) {
-	case 0x2c80:
+	case 0x9b85:
    	t->manufacturer = smbios_add_string(t->eos,
    					    "Crucial");
    	break;
@@ -172,9 +172,9 @@
    	t->manufacturer = smbios_add_string(t->eos,
    					    "Hynix/Hyundai");
    	break;
-	case 0xb502:
+	case 0x3486:
    	t->manufacturer = smbios_add_string(t->eos,
-						    "SuperTalent");
+						    "Super Talent");
    	break;
    case 0xcd04:
    	t->manufacturer = smbios_add_string(t->eos,
@@ -188,7 +188,7 @@
    	t->manufacturer = smbios_add_string(t->eos,
    					    "Elpida");
    	break;
-	case 0xff2c:
+	case 0x2c80:
    	t->manufacturer = smbios_add_string(t->eos,
    					    "Micron");
    	break;