Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/27928
Change subject: device/pci_device.c: Remove unused variable attr setting ......................................................................
device/pci_device.c: Remove unused variable attr setting
In procedure pci_get_resource, when setting an IO mapped base address, variable attr is &= with PCI_BASE_ADDRESS_IO_ATTR_MASK. However, in this particular code flow variable attr is not used later. Remove the line.
BUG=b:112253891 TEST=Build and boot grunt.
Change-Id: Ia4fdda1be92d22017a7a913a911db15aaa440b69 Signed-off-by: Richard Spiegel richard.spiegel@silverbackltd.com --- M src/device/pci_device.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/27928/1
diff --git a/src/device/pci_device.c b/src/device/pci_device.c index 5938389..b4a8a5c 100644 --- a/src/device/pci_device.c +++ b/src/device/pci_device.c @@ -249,7 +249,6 @@ resource->flags = 0; } else if (attr & PCI_BASE_ADDRESS_SPACE_IO) { /* An I/O mapped base address. */ - attr &= PCI_BASE_ADDRESS_IO_ATTR_MASK; resource->flags |= IORESOURCE_IO; /* I don't want to deal with 32bit I/O resources. */ resource->limit = 0xffff;