Attention is currently required from: Mac Chiang, Pranava Y N, Weimin Wu.
Naveen M has posted comments on this change by Weimin Wu. ( https://review.coreboot.org/c/coreboot/+/85571?usp=email )
Change subject: drivers/soundwire: Support Realtek ALC712 codec
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/drivers/soundwire/alc711/alc711.c:
https://review.coreboot.org/c/coreboot/+/85571/comment/6be345a3_2c56139e?usp... :
PS2, Line 13: static struct soundwire_multilane alc711_multilane = {
: };
@Naveen , can you please help here ?
understanding the original query from subrata, since there is a struct alc711_multilane defined, whether config->multilane.lane_mapping default values can be made so that when chip detection fails, it will fallback to those default values.
Actually default should always be SINGLE_LANE, if kernel doesn't get the configurations for "mipi-sdw-lane-%d-mapping" properties.
per soundwire driver team recommendation, there shouldn't be any default values for multi-lane, as it depends on the H/W design.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85571?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib79896a9fe23f2f66d6ee3a24f5a62bfa0f7a649
Gerrit-Change-Number: 85571
Gerrit-PatchSet: 2
Gerrit-Owner: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: Mac Chiang
mac.chiang@intel.com
Gerrit-Reviewer: Naveen M
naveen.m@intel.corp-partner.google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tongtong Pan
pantongtong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Naveen M
naveen.m@intel.com
Gerrit-Attention: Mac Chiang
mac.chiang@intel.com
Gerrit-Attention: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Mon, 06 Jan 2025 06:16:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Varun Upadhyay
varun.upadhyay@intel.com
Comment-In-Reply-To: Weimin Wu
wuweimin@huaqin.corp-partner.google.com