Attention is currently required from: Lance Zhao, Raul Rangel, Tim Wawrzynczak. Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63558 )
Change subject: drivers/usb/acpi: acpi_power_res_params: Add use_gpio_for_status ......................................................................
Patch Set 3:
(6 comments)
File src/acpi/device.c:
PS2:
Split this into its own commit.
Done:
https://review.coreboot.org/c/coreboot/+/63613
https://review.coreboot.org/c/coreboot/+/63558/comment/202fde45_27743945 PS2, Line 608: bool active
not required
Ack
https://review.coreboot.org/c/coreboot/+/63558/comment/cbe4b872_57253096 PS2, Line 623: f (active) : acpigen_emit_byte(LNOT_OP);
acpigen_get_tx_gpio() will already return "1" for the active state, regardless of polarity (i.e. […]
Ack
https://review.coreboot.org/c/coreboot/+/63558/comment/90d25dc5_c06f5bbf PS2, Line 698: ;
How about: […]
Done
https://review.coreboot.org/c/coreboot/+/63558/comment/93bd5240_caddc888 PS2, Line 703: /* Check if the device is already enabled before enabling it again. : This allows for skipping the sleep if it's also requested. */
Done
https://review.coreboot.org/c/coreboot/+/63558/comment/fae30e19_bfbb92d5 PS2, Line 705: acpigen_write_gpio_status_check
Hrmm I don't think we can just bail since the other GPIOs might be in a different state.
Done