Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40580 )
Change subject: [WIP] soc/intel/cometlake: Add supported ucode blobs ......................................................................
[WIP] soc/intel/cometlake: Add supported ucode blobs
Not for merge yet. Need to find out if there are other blobs for CML, too.
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: Id10b013df8ce98a4e9830782570e20fbcfad05c1 --- M src/soc/intel/cannonlake/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/40580/1
diff --git a/src/soc/intel/cannonlake/Makefile.inc b/src/soc/intel/cannonlake/Makefile.inc index c744e99..a2c9706 100644 --- a/src/soc/intel/cannonlake/Makefile.inc +++ b/src/soc/intel/cannonlake/Makefile.inc @@ -108,7 +108,7 @@ cpu_microcode_bins += 3rdparty/intel-microcode/intel-ucode/06-8e-0b cpu_microcode_bins += 3rdparty/intel-microcode/intel-ucode/06-8e-0c else ifeq ($(CONFIG_SOC_INTEL_COMETLAKE),y) -# TODO +cpu_microcode_bins += 3rdparty/intel-microcode/intel-ucode/06-8e-0c endif
CPPFLAGS_common += -I$(src)/soc/intel/cannonlake
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40580 )
Change subject: soc/intel/cometlake: Add ucode from repo ......................................................................
Patch Set 3:
This change is ready for review.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40580
to look at the new patch set (#4).
Change subject: soc/intel/cometlake: Add ucode from repo ......................................................................
soc/intel/cometlake: Add ucode from repo
On Comet Lake, add the following microcode updates from the 3rdparty repository: - 06-8e-0c (CPUID: 0x806ec) - 06-a6-00 (CPUID: 0xa0660)
Tested with Clevo N141CU
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: Id10b013df8ce98a4e9830782570e20fbcfad05c1 --- M src/soc/intel/cannonlake/Kconfig M src/soc/intel/cannonlake/Makefile.inc 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/40580/4
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40580 )
Change subject: soc/intel/cometlake: Add ucode from repo ......................................................................
Patch Set 4: Code-Review+2
Wheeeee!
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40580
to look at the new patch set (#5).
Change subject: soc/intel/cometlake: Add ucode from repo ......................................................................
soc/intel/cometlake: Add ucode from repo
On Comet Lake, add the following microcode updates from the 3rdparty repository: - 06-8e-0c (CPUID: 0x806ec) - 06-a6-00 (CPUID: 0xa0660)
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: Id10b013df8ce98a4e9830782570e20fbcfad05c1 --- M src/soc/intel/cannonlake/Kconfig M src/soc/intel/cannonlake/Makefile.inc 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/40580/5
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40580
to look at the new patch set (#6).
Change subject: soc/intel/cometlake: Add ucode from repo ......................................................................
soc/intel/cometlake: Add ucode from repo
On Comet Lake, add the following microcode updates from the 3rdparty repository: - 06-8e-0c (CPUID: 0x806ec) - 06-a6-00 (CPUID: 0xa0660)
Tested with Clevo N141CU.
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: Id10b013df8ce98a4e9830782570e20fbcfad05c1 --- M src/soc/intel/cannonlake/Kconfig M src/soc/intel/cannonlake/Makefile.inc 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/40580/6
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40580 )
Change subject: soc/intel/cometlake: Add ucode from repo ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40580/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40580/6//COMMIT_MSG@12 PS6, Line 12: - 06-a6-00 (CPUID: 0xa0660) Both encodings are the cpuid. A little less ambiguous: the latter is usually referred to as `cpuid signature`.
https://review.coreboot.org/c/coreboot/+/40580/6/src/soc/intel/cannonlake/Ma... File src/soc/intel/cannonlake/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/40580/6/src/soc/intel/cannonlake/Ma... PS6, Line 110: else ifeq ($(CONFIG_SOC_INTEL_COMETLAKE),y) also check that CONFIG_SOC_INTEL_CANNONLAKE_PCH_H != y
https://review.coreboot.org/c/coreboot/+/40580/6/src/soc/intel/cannonlake/Ma... PS6, Line 112: cpu_microcode_bins += 3rdparty/intel-microcode/intel-ucode/06-a6-00 Please leave a comment that 06-a6-01 is missing in the repository.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40580
to look at the new patch set (#7).
Change subject: soc/intel/cometlake: Add ucode from repo ......................................................................
soc/intel/cometlake: Add ucode from repo
On Comet Lake, add the following microcode updates from the 3rdparty repository: - 06-8e-0c (CPUID signature: 0x806ec) - 06-a6-00 (CPUID signature: 0xa0660)
Tested with Clevo N141CU.
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: Id10b013df8ce98a4e9830782570e20fbcfad05c1 --- M src/soc/intel/cannonlake/Kconfig M src/soc/intel/cannonlake/Makefile.inc 2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/40580/7
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40580 )
Change subject: soc/intel/cometlake: Add ucode from repo ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40580/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40580/6//COMMIT_MSG@12 PS6, Line 12: - 06-a6-00 (CPUID: 0xa0660)
Both encodings are the cpuid. A little less ambiguous: the latter […]
Done
https://review.coreboot.org/c/coreboot/+/40580/6/src/soc/intel/cannonlake/Ma... File src/soc/intel/cannonlake/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/40580/6/src/soc/intel/cannonlake/Ma... PS6, Line 112: cpu_microcode_bins += 3rdparty/intel-microcode/intel-ucode/06-a6-00
Please leave a comment that 06-a6-01 is missing in the repository.
Done
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40580 )
Change subject: soc/intel/cometlake: Add ucode from repo ......................................................................
Patch Set 7: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40580 )
Change subject: soc/intel/cometlake: Add ucode from repo ......................................................................
Patch Set 7: -Code-Review
ooops
Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40580
to look at the new patch set (#8).
Change subject: soc/intel/cometlake: Add ucode from repo ......................................................................
soc/intel/cometlake: Add ucode from repo
On Comet Lake, add the following microcode updates from the 3rdparty repository: - 06-8e-0c (CPUID signature: 0x806ec) - 06-a6-00 (CPUID signature: 0xa0660)
Tested with Clevo N141CU.
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: Id10b013df8ce98a4e9830782570e20fbcfad05c1 --- M src/soc/intel/cannonlake/Kconfig M src/soc/intel/cannonlake/Makefile.inc 2 files changed, 5 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/40580/8
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40580 )
Change subject: soc/intel/cometlake: Add ucode from repo ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40580/6/src/soc/intel/cannonlake/Ma... File src/soc/intel/cannonlake/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/40580/6/src/soc/intel/cannonlake/Ma... PS6, Line 110: else ifeq ($(CONFIG_SOC_INTEL_COMETLAKE),y)
also check that CONFIG_SOC_INTEL_CANNONLAKE_PCH_H != y
Done
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40580 )
Change subject: soc/intel/cometlake: Add ucode from repo ......................................................................
Patch Set 8: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40580 )
Change subject: soc/intel/cometlake: Add ucode from repo ......................................................................
soc/intel/cometlake: Add ucode from repo
On Comet Lake, add the following microcode updates from the 3rdparty repository: - 06-8e-0c (CPUID signature: 0x806ec) - 06-a6-00 (CPUID signature: 0xa0660)
Tested with Clevo N141CU.
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: Id10b013df8ce98a4e9830782570e20fbcfad05c1 Reviewed-on: https://review.coreboot.org/c/coreboot/+/40580 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/soc/intel/cannonlake/Kconfig M src/soc/intel/cannonlake/Makefile.inc 2 files changed, 5 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index 9bd57a3..6a86576 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -39,7 +39,6 @@ config SOC_INTEL_COMETLAKE bool select SOC_INTEL_CANNONLAKE_BASE - select MICROCODE_BLOB_UNDISCLOSED select FSP_USES_CB_STACK select HAVE_INTEL_FSP_REPO help diff --git a/src/soc/intel/cannonlake/Makefile.inc b/src/soc/intel/cannonlake/Makefile.inc index c744e99..e060581 100644 --- a/src/soc/intel/cannonlake/Makefile.inc +++ b/src/soc/intel/cannonlake/Makefile.inc @@ -108,7 +108,11 @@ cpu_microcode_bins += 3rdparty/intel-microcode/intel-ucode/06-8e-0b cpu_microcode_bins += 3rdparty/intel-microcode/intel-ucode/06-8e-0c else ifeq ($(CONFIG_SOC_INTEL_COMETLAKE),y) -# TODO +ifneq ($(CONFIG_SOC_INTEL_CANNONLAKE_PCH_H),y) +# Missing 06-a6-01 +cpu_microcode_bins += 3rdparty/intel-microcode/intel-ucode/06-8e-0c +cpu_microcode_bins += 3rdparty/intel-microcode/intel-ucode/06-a6-00 +endif endif
CPPFLAGS_common += -I$(src)/soc/intel/cannonlake
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40580 )
Change subject: soc/intel/cometlake: Add ucode from repo ......................................................................
Patch Set 9:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2774 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2773 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2772 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/2771
Please note: This test is under development and might not be accurate at all!