Attention is currently required from: Timofey Komarov, Felix Singer, Angel Pons, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52692 )
Change subject: soc/intel/skylake: Add Kconfig option for LGA1151v2
......................................................................
Patch Set 9: Code-Review+2
(1 comment)
File src/soc/intel/skylake/Kconfig:
https://review.coreboot.org/c/coreboot/+/52692/comment/0d145f55_1d2692c4
PS9, Line 327: default y
:
: if SKYLAKE_SOC_PCH_H
:
: config MAINBOARD_SUPPORTS_KABYLAKE_CPU
: bool "Board can contain Kaby Lake CPU"
: default y if SOC_INTEL_KABYLAKE
These should `default n if SOC_INTEL_SKYLAKE_LGA1151_V2`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52692
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b6b9c676da55088cb5a12a218ea58d349ee440c
Gerrit-Change-Number: 52692
Gerrit-PatchSet: 9
Gerrit-Owner: Timofey Komarov
happycorsair@yandex.ru
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Timofey Komarov
happycorsair@yandex.ru
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sat, 01 May 2021 16:13:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment