Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30360 )
Change subject: mb/libretrend/lt1000: Add Libretrend LT1000 board support
......................................................................
Patch Set 15:
Patch Set 15:
Patch Set 15:
Patch Set 15:
Board status available for review: https://review.coreboot.org/cgit/board-status.git/tree/libretrend/lt1000/4.1...
Thank you. As written in the other review, for commits not in the master branch, please add the source for your upload to the board status commit message.
Looking at the data, the FspMemoryInit is *very* slow.
+ 950:calling FspMemoryInit 319,239 (193,169)
+ 951:returning from FspMemoryInit 17,456,411 (17,137,171)
Hmm should I force push the board_status repository?
The MemoryInit is horrible with Kaby Lake FSP. It is also very slow on Protectli FW6, but I think it is a matter of DDR4. DDR3 could be faster probably.
Vendor BIOS also initializes the memory very slowly on both FW6 and LT1000, for reference, so I assumed it just has to be like that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30360
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I32fc8a7d3177ba379d04ad8b87adefcfca2b0fab
Gerrit-Change-Number: 30360
Gerrit-PatchSet: 15
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 06 Mar 2020 15:07:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment