Attention is currently required from: Anil Kumar K, Subrata Banik, Michael Niewöhner, Patrick Rudolph.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62192 )
Change subject: soc/intel/common: Retry END_OF_POST command
......................................................................
Patch Set 9:
(3 comments)
Patchset:
PS9:
Tested on out-of-tree Clevo L140MU (TGL): […]
@Michael,
Thanks for checking. Do you have system which shows reported EOP issue? or did you simulate the issue to try the EOP retry CL?
File src/soc/intel/common/block/cse/cse_eop.c:
https://review.coreboot.org/c/coreboot/+/62192/comment/f8c246bb_f6ec665b
PS9, Line 102: printk(BIOS_ERR, "HECI: EOP send/receive fail\n");
note: we are dropping this serial msg now?
handle_cse_eop_result() logs the error message, hence it was removed.
https://review.coreboot.org/c/coreboot/+/62192/comment/2aecc6cd_295b30f2
PS9, Line 144: size_t retry
nit: move inside for loop itself?
Outside of for loop still should be fine!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62192
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieaec4d5564e3d962c1cc866351e9e7eaa8e58683
Gerrit-Change-Number: 62192
Gerrit-PatchSet: 9
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 07 Mar 2022 06:43:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment