Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45747 )
Change subject: soc/intel/tigerlake: Replace soc_get_pmc_mux_device with device pointers ......................................................................
Patch Set 8: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/45747/7/src/ec/google/chromeec/chip... File src/ec/google/chromeec/chip.h:
https://review.coreboot.org/c/coreboot/+/45747/7/src/ec/google/chromeec/chip... PS7, Line 6: #include <stddef.h> #include <device/device.h>?
https://review.coreboot.org/c/coreboot/+/45747/8/src/ec/google/chromeec/ec_a... File src/ec/google/chromeec/ec_acpi.c:
https://review.coreboot.org/c/coreboot/+/45747/8/src/ec/google/chromeec/ec_a... PS8, Line 138: for (i = 0; i < num_ports; ++i) { Should there be a check here: if (config->mux_conn[i] == NULL) { printk(BIOS_ERR, "Error: Mux connector info missing for Type-C port #%d\n", i); continue; }
https://review.coreboot.org/c/coreboot/+/45747/8/src/ec/google/chromeec/ec_a... PS8, Line 146: get_usb_port_references Not for this change, but I think we can use the alias mechanism for usb2/3/4 ports as well so that we don't have to parse the entire tree looking for matching ports.