Change in ...coreboot[master]: mb/google/hatch: [TEST- ONLY] Enable RMT log capture in FSP

[Aamir Bohra (Code Review)]

Aamir Bohra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30664

Change subject: mb/google/hatch: [TEST- ONLY] Enable RMT log capture in FSP
......................................................................

mb/google/hatch: [TEST- ONLY] Enable RMT log capture in FSP

**** DO NOT MERGE ****

Change-Id: I0a0865b2baa6d3606a38b9f07b1d32f13e4e7178
Signed-off-by: Aamir Bohra 
---
M src/mainboard/google/hatch/romstage.c
1 file changed, 6 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/30664/1

diff --git a/src/mainboard/google/hatch/romstage.c b/src/mainboard/google/hatch/romstage.c
index 401f41f..4a47d12 100644
--- a/src/mainboard/google/hatch/romstage.c
+++ b/src/mainboard/google/hatch/romstage.c
@@ -19,11 +19,14 @@

void mainboard_memory_init_params(FSPM_UPD *memupd)
 {
+       FSP_M_CONFIG *mem_cfg = &memupd->FspmConfig;
+       mem_cfg->RMT = 1;
+       memupd->FspmTestConfig.BdatEnable = 1;
+       mem_cfg->MrcFastBoot = 0;
+
    const struct spd_info spd = {
    	.spd_by_index = true,
    	.spd_spec.spd_index = variant_memory_sku(),
    };
-
-	cannonlake_memcfg_init(&memupd->FspmConfig,
-			variant_memory_params(), &spd);
+	cannonlake_memcfg_init(mem_cfg, variant_memory_params(), &spd);
 }

[Aamir Bohra (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/30664

to look at the new patch set (#3).

Change subject: mb/google/hatch: [TEST- ONLY] Enable RMT log capture in FSP
......................................................................

mb/google/hatch: [TEST- ONLY] Enable RMT log capture in FSP

**** DO NOT MERGE ****

Change-Id: I0a0865b2baa6d3606a38b9f07b1d32f13e4e7178
Signed-off-by: Aamir Bohra 
---
M src/mainboard/google/hatch/romstage.c
1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/30664/3

Change in coreboot[master]: mb/google/hatch: [TEST- ONLY] Enable RMT log capture in FSP

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30664 )

Change subject: mb/google/hatch: [TEST- ONLY] Enable RMT log capture in FSP
......................................................................

Patch Set 3:

I am curious: can the FSP binary in https://github.com/IntelFsp/FSP output said RMT data, or does this require a debug build of FSP?

[XS] Change in coreboot[master]: mb/google/hatch: [TEST- ONLY] Enable RMT log capture in FSP

[Stefan Reinauer (Code Review)]

Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/30664?usp=email )

Change subject: mb/google/hatch: [TEST- ONLY] Enable RMT log capture in FSP
......................................................................

Abandoned