Attention is currently required from: Hung-Te Lin, Jason Glenesk, Raul Rangel, Marshall Dawson, Tim Wawrzynczak, Christian Walter, Julius Werner, Arthur Heymans, Andrey Petrov, Fred Reitberger, Yu-Ping Wu, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63375 )
Change subject: [RFC] CBMEM: Have INIT_HOOKS in every stage ......................................................................
Patch Set 4:
(6 comments)
File src/include/cbmem.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145693): https://review.coreboot.org/c/coreboot/+/63375/comment/1f3f2fc3_ee112e70 PS4, Line 110: #define _CBMEM_INIT_HOOK_UNUSED(init_fn_) __attribute__((unused)) \ macros should not use a trailing semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145693): https://review.coreboot.org/c/coreboot/+/63375/comment/5fc2c1af_c5cf6262 PS4, Line 113: #define _CBMEM_INIT_HOOK(init_fn_) \ macros should not use a trailing semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145693): https://review.coreboot.org/c/coreboot/+/63375/comment/f7e88f11_6ec554fc PS4, Line 119: #define _CBMEM_INIT_HOOK_EARLY(init_fn_) \ macros should not use a trailing semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145693): https://review.coreboot.org/c/coreboot/+/63375/comment/8d468181_c496b06d PS4, Line 124: #define CBMEM_CREATION_HOOK(x) _CBMEM_INIT_HOOK(x) please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145693): https://review.coreboot.org/c/coreboot/+/63375/comment/511020dd_c6c0f746 PS4, Line 126: #define CBMEM_CREATION_HOOK(x) _CBMEM_INIT_HOOK_UNUSED(x) please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145693): https://review.coreboot.org/c/coreboot/+/63375/comment/166eff0e_62527d6e PS4, Line 130: #define CBMEM_INIT_HOOK(x) _CBMEM_INIT_HOOK(x) please, no space before tabs
-
build bot (Jenkins) (Code Review)