Attention is currently required from: Raul Rangel, Paul Menzel. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64004 )
Change subject: mb/google/skyrim/var/skyrim: Add USB WWAN configuration ......................................................................
Patch Set 6:
(2 comments)
File src/mainboard/google/skyrim/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/64004/comment/392a0431_c72c849d PS5, Line 27: LOW
Why not leave it enabled so it's ready by the time the OS boots?
They have a specific power sequence requirement during cold resets, warm resets and firmware update. In order not to mess up with power sequencing done through ACPI, leaving it disabled in the firmware.
File src/mainboard/google/skyrim/variants/skyrim/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/64004/comment/77b83bd5_a01a9d5d PS1, Line 54: register "reset_off_delay_ms" = "20"
Please mention the source of the values in the commit message.
Done
-
Karthik Ramasubramanian (Code Review)