Change in coreboot[master]: 3rdparty/blobs: Add Facebook FBG1701 descriptor and Intel ME

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Frans Hendriks (Code Review)

19 Jul 2019 19 Jul '19

10:26 a.m.

Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34442 )

Change subject: 3rdparty/blobs: Add Facebook FBG1701 descriptor and Intel ME ......................................................................

3rdparty/blobs: Add Facebook FBG1701 descriptor and Intel ME

Upgrade to blobs version with descriptor and Intel ME binary

BUG=N/A TEST=booting Facebook FBG1701

Change-Id: I2143b94a81eebfb22d99833aaf1f3743983dd80c Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M 3rdparty/blobs 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/34442/1

diff --git a/3rdparty/blobs b/3rdparty/blobs index d7600dd..c7dc4f2 160000 --- a/3rdparty/blobs +++ b/3rdparty/blobs @@ -1 +1 @@ -Subproject commit d7600dd8718a076f0f9a89e53968b484254624dc +Subproject commit c7dc4f25229fd3c022afdb410264b02f292ddca6

Attachments:

attachment.htm (text/html — 2.2 KB)

Show replies by date

Frans Hendriks (Code Review)

9 Aug 9 Aug

12:32 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34442

to look at the new patch set (#2).

Change subject: 3rdparty/blobs: Add Facebook FBG1701 descriptor and Intel ME ......................................................................

3rdparty/blobs: Add Facebook FBG1701 descriptor and Intel ME

Upgrade to blobs version with descriptor and Intel ME binary

BUG=N/A TEST=booting Facebook FBG1701

Change-Id: I2143b94a81eebfb22d99833aaf1f3743983dd80c Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M 3rdparty/blobs 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/34442/2

Patrick Georgi (Code Review)

15 Nov 15 Nov

11:40 a.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34442 )

Change subject: 3rdparty/blobs: Add Facebook FBG1701 descriptor and Intel ME ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34442/2/3rdparty/blobs File 3rdparty/blobs:

PS2: this points to an older version of what was ultimately merged the commit ID in question is 034b27818450428f70aa9316c8bd0d65bacd8ee8, so please update

-- To view, visit https://review.coreboot.org/c/coreboot/+/34442 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2143b94a81eebfb22d99833aaf1f3743983dd80c Gerrit-Change-Number: 34442 Gerrit-PatchSet: 2 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 15 Nov 2019 10:40:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Frans Hendriks (Code Review)

12:47 p.m.

Hello Patrick Rudolph, Felix Held, Wim Vervoorn, build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34442

to look at the new patch set (#3).

Change subject: 3rdparty/blobs: Add Facebook FBG1701 descriptor and Intel ME ......................................................................

3rdparty/blobs: Add Facebook FBG1701 descriptor and Intel ME

Upgrade to blobs version with descriptor and Intel ME binary

BUG=N/A TEST=booting Facebook FBG1701

Change-Id: I2143b94a81eebfb22d99833aaf1f3743983dd80c Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M 3rdparty/blobs 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/34442/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/34442 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2143b94a81eebfb22d99833aaf1f3743983dd80c Gerrit-Change-Number: 34442 Gerrit-PatchSet: 3 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Frans Hendriks (Code Review)

12:48 p.m.

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34442 )

Change subject: 3rdparty/blobs: Add Facebook FBG1701 descriptor and Intel ME ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34442/2/3rdparty/blobs File 3rdparty/blobs:

PS2:

...

this points to an older version of what was ultimately merged the commit ID in question is 034b27818 […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/34442 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2143b94a81eebfb22d99833aaf1f3743983dd80c Gerrit-Change-Number: 34442 Gerrit-PatchSet: 3 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 15 Nov 2019 11:48:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

12:50 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34442 )

Change subject: 3rdparty/blobs: Add Facebook FBG1701 descriptor and Intel ME ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/34442 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2143b94a81eebfb22d99833aaf1f3743983dd80c Gerrit-Change-Number: 34442 Gerrit-PatchSet: 3 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 15 Nov 2019 11:50:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Wim Vervoorn (Code Review)

2:15 p.m.

Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34442 )

Change subject: 3rdparty/blobs: Add Facebook FBG1701 descriptor and Intel ME ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/34442 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2143b94a81eebfb22d99833aaf1f3743983dd80c Gerrit-Change-Number: 34442 Gerrit-PatchSet: 3 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 15 Nov 2019 13:15:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

2:17 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/34442 )

Change subject: 3rdparty/blobs: Add Facebook FBG1701 descriptor and Intel ME ......................................................................

3rdparty/blobs: Add Facebook FBG1701 descriptor and Intel ME

Upgrade to blobs version with descriptor and Intel ME binary

BUG=N/A TEST=booting Facebook FBG1701

Change-Id: I2143b94a81eebfb22d99833aaf1f3743983dd80c Signed-off-by: Frans Hendriks fhendriks@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34442 Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Wim Vervoorn wvervoorn@eltan.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M 3rdparty/blobs 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Wim Vervoorn: Looks good to me, but someone else must approve

diff --git a/3rdparty/blobs b/3rdparty/blobs index 62aa0e0..034b278 160000 --- a/3rdparty/blobs +++ b/3rdparty/blobs @@ -1 +1 @@ -Subproject commit 62aa0e0c54295bbb7b1a3e5e73f960bafdb59d04 +Subproject commit 034b27818450428f70aa9316c8bd0d65bacd8ee8

-- To view, visit https://review.coreboot.org/c/coreboot/+/34442 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2143b94a81eebfb22d99833aaf1f3743983dd80c Gerrit-Change-Number: 34442 Gerrit-PatchSet: 4 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1992

days inactive

2111

days old

coreboot-gerrit@coreboot.org

7 comments

3 participants

tags (0)

participants (3)

Frans Hendriks (Code Review)
Patrick Georgi (Code Review)
Wim Vervoorn (Code Review)