Change in coreboot[master]: mainboard/facebook/fbg1701: Add IFD and ME binary

List overview All Threads
Download

newer

older

Change in em100[master]: em100:...

Change in coreboot[master]:...

Frans Hendriks (Code Review)

19 Jul 2019 19 Jul '19

11:12 a.m.

Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34448 )

Change subject: mainboard/facebook/fbg1701: Add IFD and ME binary ......................................................................

mainboard/facebook/fbg1701: Add IFD and ME binary

Use IFD and ME binary to generate complete SPI image

BUG=N/A TEST=Boot Embedded Linux 4.20 on Facebook FBG-1701

Change-Id: I9370bf9f2bba8887988bc6484524f6cf53bed8db Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/facebook/fbg1701/Kconfig 1 file changed, 10 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/34448/1

diff --git a/src/mainboard/facebook/fbg1701/Kconfig b/src/mainboard/facebook/fbg1701/Kconfig index 95d8f6c..dce315e 100644 --- a/src/mainboard/facebook/fbg1701/Kconfig +++ b/src/mainboard/facebook/fbg1701/Kconfig @@ -19,6 +19,8 @@ def_bool y select BOARD_ROMSIZE_KB_8192 select HAVE_ACPI_TABLES + select HAVE_IFD_BIN + select HAVE_ME_BIN select HAVE_OPTION_TABLE select MAINBOARD_HAS_LPC_TPM select MAINBOARD_HAS_TPM2 @@ -94,4 +96,12 @@ hex "C Bootblock Size" default 0x4000

+config IFD_BIN_PATH + string + default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/descriptor.bin" + +config ME_BIN_PATH + string + default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/me.bin" + endif # BOARD_FACEBOOK_FBG1701

Attachments:

attachment.htm (text/html — 3.3 KB)

Show replies by date

Arthur Heymans (Code Review)

24 Jul 24 Jul

5:23 p.m.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34448 )

Change subject: mainboard/facebook/fbg1701: Add IFD and ME binary ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34448/2/src/mainboard/facebook/fbg1... File src/mainboard/facebook/fbg1701/Kconfig:

https://review.coreboot.org/c/coreboot/+/34448/2/src/mainboard/facebook/fbg1... PS2, Line 99: config IFD_BIN_PATH : string : default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/descriptor.bin" : : config ME_BIN_PATH : string : default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/me.bin" already default in southbridge/intel/common/firmware/Kconfig

Frans Hendriks (Code Review)

25 Jul 25 Jul

9:12 a.m.

New subject: Change in coreboot[master]: mainboard/facebook/fbg1701: Select HAVE_IFD_BIN and HAVE_ME_BIN

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34448

to look at the new patch set (#3).

Change subject: mainboard/facebook/fbg1701: Select HAVE_IFD_BIN and HAVE_ME_BIN ......................................................................

mainboard/facebook/fbg1701: Select HAVE_IFD_BIN and HAVE_ME_BIN

Add IFD and ME binary to generate complete SPI image.

BUG=N/A TEST=Boot Embedded Linux 4.20 on Facebook FBG-1701

Change-Id: I9370bf9f2bba8887988bc6484524f6cf53bed8db Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/facebook/fbg1701/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/34448/3

Frans Hendriks (Code Review)

11:28 a.m.

New subject: Change in coreboot[master]: mainboard/facebook/fbg1701: Select HAVE_IFD_BIN and HAVE_ME_BIN

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34448 )

Change subject: mainboard/facebook/fbg1701: Select HAVE_IFD_BIN and HAVE_ME_BIN ......................................................................

Patch Set 4:

(1 comment)

Implement comment

https://review.coreboot.org/c/coreboot/+/34448/2/src/mainboard/facebook/fbg1... File src/mainboard/facebook/fbg1701/Kconfig:

...

already default in southbridge/intel/common/firmware/Kconfig

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/34448 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9370bf9f2bba8887988bc6484524f6cf53bed8db Gerrit-Change-Number: 34448 Gerrit-PatchSet: 4 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 25 Jul 2019 09:28:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz Gerrit-MessageType: comment

Paul Menzel (Code Review)

2:28 p.m.

New subject: Change in coreboot[master]: mainboard/facebook/fbg1701: Select HAVE_IFD_BIN and HAVE_ME_BIN

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34448 )

Change subject: mainboard/facebook/fbg1701: Select HAVE_IFD_BIN and HAVE_ME_BIN ......................................................................

Patch Set 4: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/34448 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9370bf9f2bba8887988bc6484524f6cf53bed8db Gerrit-Change-Number: 34448 Gerrit-PatchSet: 4 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 25 Jul 2019 12:28:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Frans Hendriks (Code Review)

2 Aug 2 Aug

9:40 a.m.

New subject: Change in coreboot[master]: mb/facebook/fbg1701: Select HAVE_IFD_BIN and HAVE_ME_BIN

Hello Felix Held, Arthur Heymans, Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34448

to look at the new patch set (#5).

Change subject: mb/facebook/fbg1701: Select HAVE_IFD_BIN and HAVE_ME_BIN ......................................................................

mb/facebook/fbg1701: Select HAVE_IFD_BIN and HAVE_ME_BIN

Add IFD and ME binary to generate complete SPI image.

BUG=N/A TEST=Boot Embedded Linux 4.20 on Facebook FBG-1701

Change-Id: I9370bf9f2bba8887988bc6484524f6cf53bed8db Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/facebook/fbg1701/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/34448/5

Wim Vervoorn (Code Review)

18 Oct 18 Oct

9:03 a.m.

New subject: Change in coreboot[master]: mb/facebook/fbg1701: Select HAVE_IFD_BIN and HAVE_ME_BIN

Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34448 )

Change subject: mb/facebook/fbg1701: Select HAVE_IFD_BIN and HAVE_ME_BIN ......................................................................

Patch Set 5: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/34448 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9370bf9f2bba8887988bc6484524f6cf53bed8db Gerrit-Change-Number: 34448 Gerrit-PatchSet: 5 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Wim Vervoorn Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 18 Oct 2019 07:03:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

15 Nov 15 Nov

12:50 p.m.

New subject: Change in coreboot[master]: mb/facebook/fbg1701: Select HAVE_IFD_BIN and HAVE_ME_BIN

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34448 )

Change subject: mb/facebook/fbg1701: Select HAVE_IFD_BIN and HAVE_ME_BIN ......................................................................

Patch Set 5: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/34448 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9370bf9f2bba8887988bc6484524f6cf53bed8db Gerrit-Change-Number: 34448 Gerrit-PatchSet: 5 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 15 Nov 2019 11:50:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

2:17 p.m.

New subject: Change in coreboot[master]: mb/facebook/fbg1701: Select HAVE_IFD_BIN and HAVE_ME_BIN

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/34448 )

Change subject: mb/facebook/fbg1701: Select HAVE_IFD_BIN and HAVE_ME_BIN ......................................................................

mb/facebook/fbg1701: Select HAVE_IFD_BIN and HAVE_ME_BIN

Add IFD and ME binary to generate complete SPI image.

BUG=N/A TEST=Boot Embedded Linux 4.20 on Facebook FBG-1701

Change-Id: I9370bf9f2bba8887988bc6484524f6cf53bed8db Signed-off-by: Frans Hendriks fhendriks@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34448 Reviewed-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/facebook/fbg1701/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Wim Vervoorn: Looks good to me, but someone else must approve

diff --git a/src/mainboard/facebook/fbg1701/Kconfig b/src/mainboard/facebook/fbg1701/Kconfig index 5e71db0..c92626b 100644 --- a/src/mainboard/facebook/fbg1701/Kconfig +++ b/src/mainboard/facebook/fbg1701/Kconfig @@ -19,6 +19,8 @@ def_bool y select BOARD_ROMSIZE_KB_8192 select HAVE_ACPI_TABLES + select HAVE_IFD_BIN + select HAVE_ME_BIN select HAVE_OPTION_TABLE select MAINBOARD_HAS_LPC_TPM select MAINBOARD_HAS_TPM2

-- To view, visit https://review.coreboot.org/c/coreboot/+/34448 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9370bf9f2bba8887988bc6484524f6cf53bed8db Gerrit-Change-Number: 34448 Gerrit-PatchSet: 6 Gerrit-Owner: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1638

days inactive

1757

days old

coreboot-gerrit@coreboot.org

8 comments

5 participants

tags (0)

participants (5)

Arthur Heymans (Code Review)
Frans Hendriks (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)
Wim Vervoorn (Code Review)