Attention is currently required from: Subrata Banik.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50130 )
Change subject: soc/intel/alderlake: Create separate Kconfig for CLKSRC and CLKREQ
......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/alderlake/chip.h:
https://review.coreboot.org/c/coreboot/+/50130/comment/8b286601_a2d427a0
PS4, Line 137: CONFIG_MAX_PCIE_CLOCK_REQ
This is not correct. The index for PcieClkSrcClkReq is clock source and the value is clock req. Thus, the array still needs to be of size `CONFIG_MAX_PCIE_CLOCK_SRC`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50130
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7d223c165f819669722cbc80245fa8ec20372352
Gerrit-Change-Number: 50130
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Tue, 02 Feb 2021 01:20:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment