Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/19571 )
Change subject: mb/lenovo/*/romstage: Remove COM IO port ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/19571/1/src/mainboard/lenovo/l520/romstage.c File src/mainboard/lenovo/l520/romstage.c:
Line 28: pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x82, 0x3c0c);
maybe use macros defined for both values and register offsets?
That can be done in a seperate commit.
Line 29: pci_write_config32(PCI_DEV(0, 0x1f, 0), 0x84, 0x007c1611);
Not the scope of this patch, but this decode range may be for the LPC docki
That's for HDAPS.