Change in coreboot[master]: device/Kconfig: Use more fine grained Kconfig for graphics init
Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49174 )
Change subject: device/Kconfig: Use more fine grained Kconfig for graphics init ......................................................................
device/Kconfig: Use more fine grained Kconfig for graphics init
Add MAINBOARD_HAS_NATIVE_INTEL_VGA_INIT.
Change-Id: I3e175f0377c3c03ae93148e1178136cc0ccaad52 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/device/Kconfig M src/mainboard/asus/p5gc-mx/Kconfig M src/mainboard/foxconn/d41s/Kconfig M src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig M src/mainboard/intel/d510mo/Kconfig M src/mainboard/intel/d945gclf/Kconfig M src/northbridge/intel/i945/Kconfig M src/northbridge/intel/pineview/Kconfig 8 files changed, 14 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/49174/1
diff --git a/src/device/Kconfig b/src/device/Kconfig index a472a6a..789e239 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -39,6 +39,13 @@ Selected by mainboards / drivers that provide native graphics init within coreboot.
+config MAINBOARD_HAS_NATIVE_INTEL_VGA_INIT + def_bool n + select MAINBOARD_HAS_NATIVE_VGA_INIT + help + Selected by mainboards / drivers that provide native graphics + init for Intel GPUs within coreboot. + config MAINBOARD_FORCE_NATIVE_VGA_INIT def_bool n depends on MAINBOARD_HAS_NATIVE_VGA_INIT || MAINBOARD_HAS_LIBGFXINIT diff --git a/src/mainboard/asus/p5gc-mx/Kconfig b/src/mainboard/asus/p5gc-mx/Kconfig index a0dc96e7..280cf8c 100644 --- a/src/mainboard/asus/p5gc-mx/Kconfig +++ b/src/mainboard/asus/p5gc-mx/Kconfig @@ -15,7 +15,7 @@ select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select BOARD_ROMSIZE_KB_512 - select MAINBOARD_HAS_NATIVE_VGA_INIT + select MAINBOARD_HAS_NATIVE_INTEL_VGA_INIT select INTEL_GMA_HAVE_VBT select NO_CBFS_MCACHE
diff --git a/src/mainboard/foxconn/d41s/Kconfig b/src/mainboard/foxconn/d41s/Kconfig index 93ce389..47b0b4c 100644 --- a/src/mainboard/foxconn/d41s/Kconfig +++ b/src/mainboard/foxconn/d41s/Kconfig @@ -11,7 +11,7 @@ select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select BOARD_ROMSIZE_KB_1024 - select MAINBOARD_HAS_NATIVE_VGA_INIT + select MAINBOARD_HAS_NATIVE_INTEL_VGA_INIT select INTEL_INT15 select HAVE_OPTION_TABLE select HAVE_CMOS_DEFAULT diff --git a/src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig b/src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig index f6a99e7..e013ed2 100644 --- a/src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig +++ b/src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig @@ -15,7 +15,7 @@ select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select BOARD_ROMSIZE_KB_512 - select MAINBOARD_HAS_NATIVE_VGA_INIT + select MAINBOARD_HAS_NATIVE_INTEL_VGA_INIT select REALTEK_8168_RESET if BOARD_GIGABYTE_GA_945GCM_S2L select INTEL_GMA_HAVE_VBT select NO_CBFS_MCACHE diff --git a/src/mainboard/intel/d510mo/Kconfig b/src/mainboard/intel/d510mo/Kconfig index cd6260b..0482dab 100644 --- a/src/mainboard/intel/d510mo/Kconfig +++ b/src/mainboard/intel/d510mo/Kconfig @@ -11,7 +11,7 @@ select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select BOARD_ROMSIZE_KB_1024 - select MAINBOARD_HAS_NATIVE_VGA_INIT + select MAINBOARD_HAS_NATIVE_INTEL_VGA_INIT select INTEL_INT15 select HAVE_OPTION_TABLE select HAVE_CMOS_DEFAULT diff --git a/src/mainboard/intel/d945gclf/Kconfig b/src/mainboard/intel/d945gclf/Kconfig index 06e1a0c..e2ab01e 100644 --- a/src/mainboard/intel/d945gclf/Kconfig +++ b/src/mainboard/intel/d945gclf/Kconfig @@ -16,7 +16,7 @@ select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME select BOARD_ROMSIZE_KB_512 - select MAINBOARD_HAS_NATIVE_VGA_INIT + select MAINBOARD_HAS_NATIVE_INTEL_VGA_INIT select INTEL_GMA_HAVE_VBT
config MAINBOARD_DIR diff --git a/src/northbridge/intel/i945/Kconfig b/src/northbridge/intel/i945/Kconfig index d6498f1..091d2f1 100644 --- a/src/northbridge/intel/i945/Kconfig +++ b/src/northbridge/intel/i945/Kconfig @@ -31,7 +31,7 @@
config I945_LVDS def_bool n - select MAINBOARD_HAS_NATIVE_VGA_INIT + select MAINBOARD_HAS_NATIVE_INTEL_VGA_INIT select HAVE_LINEAR_FRAMEBUFFER if MAINBOARD_DO_NATIVE_VGA_INIT help Selected by mainboards that use native graphics initialization diff --git a/src/northbridge/intel/pineview/Kconfig b/src/northbridge/intel/pineview/Kconfig index 185beebe..962825a 100644 --- a/src/northbridge/intel/pineview/Kconfig +++ b/src/northbridge/intel/pineview/Kconfig @@ -9,7 +9,7 @@ def_bool y select HAVE_DEBUG_RAM_SETUP select VGA - select MAINBOARD_HAS_NATIVE_VGA_INIT + select MAINBOARD_HAS_NATIVE_INTEL_VGA_INIT select HAVE_VGA_TEXT_FRAMEBUFFER if MAINBOARD_DO_NATIVE_VGA_INIT select INTEL_EDID if MAINBOARD_DO_NATIVE_VGA_INIT select INTEL_GMA_ACPI
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49174 )
Change subject: device/Kconfig: Use more fine grained Kconfig for graphics init ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/49174/1/src/mainboard/foxconn/d41s/... File src/mainboard/foxconn/d41s/Kconfig:
https://review.coreboot.org/c/coreboot/+/49174/1/src/mainboard/foxconn/d41s/... PS1, Line 14: select MAINBOARD_HAS_NATIVE_INTEL_VGA_INIT Redundant, already selected from nb/intel/pineview
https://review.coreboot.org/c/coreboot/+/49174/1/src/mainboard/intel/d510mo/... File src/mainboard/intel/d510mo/Kconfig:
https://review.coreboot.org/c/coreboot/+/49174/1/src/mainboard/intel/d510mo/... PS1, Line 14: select MAINBOARD_HAS_NATIVE_INTEL_VGA_INIT Redundant, already selected from nb/intel/pineview
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49174 )
Change subject: device/Kconfig: Use more fine grained Kconfig for graphics init ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/49174/1/src/mainboard/foxconn/d41s/... File src/mainboard/foxconn/d41s/Kconfig:
https://review.coreboot.org/c/coreboot/+/49174/1/src/mainboard/foxconn/d41s/... PS1, Line 14: select MAINBOARD_HAS_NATIVE_INTEL_VGA_INIT
Redundant, already selected from nb/intel/pineview
CB:49182
https://review.coreboot.org/c/coreboot/+/49174/1/src/mainboard/intel/d510mo/... File src/mainboard/intel/d510mo/Kconfig:
https://review.coreboot.org/c/coreboot/+/49174/1/src/mainboard/intel/d510mo/... PS1, Line 14: select MAINBOARD_HAS_NATIVE_INTEL_VGA_INIT
Redundant, already selected from nb/intel/pineview
CB:49182
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49174 )
Change subject: device/Kconfig: Use more fine grained Kconfig for graphics init ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/49174/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/49174/1//COMMIT_MSG@7 PS1, Line 7: Use more fine grained Kconfig for graphics init To avoid having the same summary for two different changes, maybe say:
Add MAINBOARD_HAS_NATIVE_INTEL_VGA_INIT
Hello build bot (Jenkins), Damien Zammit, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49174
to look at the new patch set (#2).
Change subject: device/Kconfig: Add MAINBOARD_HAS_NATIVE_INTEL_VGA_INIT ......................................................................
device/Kconfig: Add MAINBOARD_HAS_NATIVE_INTEL_VGA_INIT
This will allow a more fine grained control about graphics drivers to run.
Change-Id: I3e175f0377c3c03ae93148e1178136cc0ccaad52 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/device/Kconfig M src/mainboard/asus/p5gc-mx/Kconfig M src/mainboard/foxconn/d41s/Kconfig M src/mainboard/gigabyte/ga-945gcm-s2l/Kconfig M src/mainboard/intel/d510mo/Kconfig M src/mainboard/intel/d945gclf/Kconfig M src/northbridge/intel/i945/Kconfig M src/northbridge/intel/pineview/Kconfig 8 files changed, 14 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/49174/2
Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/49174?usp=email )
Change subject: device/Kconfig: Add MAINBOARD_HAS_NATIVE_INTEL_VGA_INIT ......................................................................
Abandoned
This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.
-
Angel Pons (Code Review) -
Martin L Roth (Code Review)
-
Patrick Rudolph (Code Review)