build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27137 )
Change subject: tianocore: Add more patches ......................................................................
Patch Set 1:
(37 comments)
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... File payloads/external/tianocore/patches/08_BaseTools-Fix-building-with-Werror-stringop-truncati.patch:
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 16: } else { DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 17: Length = strlen(Str); DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 18: if (Length < 4) { DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 19: - strncpy (TemStr + 4 - Length, Str, Length); DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 20: + memcpy (TemStr + 4 - Length, Str, Length); DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 21: } else { DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 22: - strncpy (TemStr, Str + Length - 4, 4); DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 23: + memcpy (TemStr, Str + Length - 4, 4); DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 24: } DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 25: DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 26: sscanf ( DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 28: // trailing whitespace
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 29: FitStartPtr = (FIT_TABLE *) RelativeAddress; DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 30: DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 31: - strncpy ((CHAR8 *) &FitStartPtr->CompAddress, FIT_SIGNATURE, 8); // "_FIT_ " trailing whitespace
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 32: + memcpy ((CHAR8 *) &FitStartPtr->CompAddress, FIT_SIGNATURE, 8); // "_FIT_ " trailing whitespace
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 33: assert (((VtfInfo->CompSize & 0x00FFFFFF) % 16) == 0); DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 34: FitStartPtr->CompSize = (VtfInfo->CompSize & 0x00FFFFFF) / 16; DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 35: FitStartPtr->CompVersion = MAKE_VERSION (VtfInfo->MajorVer, VtfInfo->MinorVer); DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 36: -- trailing whitespace
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... File payloads/external/tianocore/patches/09_gcc7-Fix-building-with-fpermissive.patch:
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 17: UINT8 BlockType; DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 18: EFI_HII_STRING_PACKAGE_HDR *PkgHeader; DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 19: DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 20: - if (mStringFileName == '\0' ) { DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 21: + if (mStringFileName == NULL ) { DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 22: return NULL; DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 23: } DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 24: DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 30: DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 31: StringPtr = ConfigAltResp; DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 32: DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 33: - while (StringPtr != L'\0') { DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 34: + while (StringPtr != NULL) { DOS line endings
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 35: // trailing whitespace
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 36: // 1. Find <ConfigHdr> GUID=...&NAME=...&PATH=... trailing whitespace
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 37: // trailing whitespace
https://review.coreboot.org/#/c/27137/1/payloads/external/tianocore/patches/... PS1, Line 38: -- trailing whitespace
-
build bot (Jenkins) (Code Review)