Change in coreboot[master]: sb/intel/common: Refactor _PRT generation to support GSI-based tables

[Tim Wawrzynczak (Code Review)]

Attention is currently required from: Nico Huber, Furquan Shaikh, Angel Pons, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50857 )

Change subject: sb/intel/common: Refactor _PRT generation to support GSI-based tables
......................................................................

Patch Set 20:

(6 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/50857/comment/7ebedab9_1e63c807 
PS19, Line 10: insteade
> instead

Done

Patchset:

PS20: 
sorry for the bad rebase, y'all! 🙏

File src/southbridge/intel/common/acpi_pirq_gen.h:

https://review.coreboot.org/c/coreboot/+/50857/comment/30357c12_3cc86cc5 
PS19, Line 33: The type of IRQ
             :  * (GSI or PIRQ) comes from `pirq_map_type`.
             :  *
> This seems like it went back to an older patchset?

bad rebase

https://review.coreboot.org/c/coreboot/+/50857/comment/27653102_fd7e033f 
PS19, Line 39: pack
> path?

Done

File src/southbridge/intel/common/acpi_pirq_gen.c:

https://review.coreboot.org/c/coreboot/+/50857/comment/003cce90_6a0f16b2 
PS15, Line 15: /*
             : 		 * The reason for subtracting PCI_INT_A from the pin given is
             : 		 * that PCI defines pins as 1-4, and _PRT uses 0-3.
             : 		 */
> Was this intentionally dropped? Or just a bad rebase?

ugh bad rebase

File src/southbridge/intel/common/rcba_pirq.c:

https://review.coreboot.org/c/coreboot/+/50857/comment/845d3580_7d3a31f4 
PS19, Line 74: int_idx
> nit: This is used in just one place i.e. printk. […]

Ack