Attention is currently required from: Eric Lai, Nick Vaccaro, Robert Chen, Subrata Banik.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79173?usp=email )
Change subject: mb/google/nissa/var/quandiso: Disable un-used C1 port for DB_NONE
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79173/comment/c5d608b5_cc78f283 :
PS3, Line 7: DB_NONE
What does DB mean?
https://review.coreboot.org/c/coreboot/+/79173/comment/a324074a_70c9c9e2 :
PS3, Line 11:
Please document the schematic version.
File src/mainboard/google/brya/variants/quandiso/fw_config.c:
https://review.coreboot.org/c/coreboot/+/79173/comment/9fc93132_c5c0a552 :
PS3, Line 96: printk(BIOS_INFO, "Disable USBC1 AUX Pins.\n");
Info level messages should be more elaborate. Maybe add: … according to fw_config.
https://review.coreboot.org/c/coreboot/+/79173/comment/7dd88d50_6a4c5091 :
PS3, Line 96: Pins
pins
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79173?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6f702f60c772176e80b3452bf957d10625564102
Gerrit-Change-Number: 79173
Gerrit-PatchSet: 3
Gerrit-Owner: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shawn Ku
shawnku@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 20 Nov 2023 23:05:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment