Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39272 )
Change subject: EC sync: Support enabling EC EFS with EC software sync. ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39272/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39272/1//COMMIT_MSG@7 PS1, Line 7: EC sync: Support enabling EC EFS with EC software sync. 1. Please prefix with *security*. 2. Please remove the dot/period at the end.
https://review.coreboot.org/c/coreboot/+/39272/1//COMMIT_MSG@9 PS1, Line 9: EFS What is that?
https://review.coreboot.org/c/coreboot/+/39272/1//COMMIT_MSG@11 PS1, Line 11: Why can’t the vboot code in coreboot not detect that at runtime?
https://review.coreboot.org/c/coreboot/+/39272/1/src/security/vboot/Kconfig File src/security/vboot/Kconfig:
https://review.coreboot.org/c/coreboot/+/39272/1/src/security/vboot/Kconfig@... PS1, Line 264: Early-firmware No minus?
https://review.coreboot.org/c/coreboot/+/39272/1/src/security/vboot/Kconfig@... PS1, Line 268: need needs
-
Paul Menzel (Code Review)