[M] Change in coreboot[master]: cpu/intel/speedstep: Use acpigen_write_processor_device()
Attention is currently required from: Nico Huber, Arthur Heymans.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74441 )
Change subject: cpu/intel/speedstep: Use acpigen_write_processor_device() ......................................................................
Patch Set 4:
(1 comment)
File src/southbridge/intel/i82801gx/fadt.c:
https://review.coreboot.org/c/coreboot/+/74441/comment/27db38f6_b840725b PS4, Line 29: fadt->p_lvl3_lat = chip->c3_latency;
I wouldn't say the current implementation is right. But if we want to drop Processor(), shouldn't we first have an alternative ready?
Despite the removal of [WIP] I have no rush to get this in. Future OSPM still has to parse deprecated Processor(), right? If not, then this patch is better than nothing.
In any case, we shouldn't leave dead code around. AFAICT, this was the only consumer of `c3_latency`.
We also have _CST entries without C3, and _CST entries with C3 where latency does not match with the devicetree... Elsewhere I also popped the question, if it is valid to evaluate BSP MSR's to fill in AP _CST entries.
-
Kyösti Mälkki (Code Review)