Change in coreboot[master]: soc/intel/xeon_sp: Add Lewisburg defs for common/gpio driver
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39425 )
Change subject: soc/intel/xeon_sp: Add Lewisburg defs for common/gpio driver ......................................................................
Patch Set 15: Code-Review+2
(5 comments)
https://review.coreboot.org/c/coreboot/+/39425/11/src/soc/intel/xeon_sp/acpi... File src/soc/intel/xeon_sp/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/39425/11/src/soc/intel/xeon_sp/acpi... PS11, Line 5: define
Don't you need to include this file from somewhere else? Like in the main PCH asl file?
This file was removed from the change. Marking as resolved.
https://review.coreboot.org/c/coreboot/+/39425/11/src/soc/intel/xeon_sp/acpi... PS11, Line 27: /* GPIO Community 0 */ : CreateDWordField (^RBUF, ^COM0._BAS, BAS0) : CreateDWordField (^RBUF, ^COM0._LEN, LEN0) :
actually it compiles fine, I was just stuffing this in wrong acpi namespace. […]
This file was removed from the change. Marking as resolved.
https://review.coreboot.org/c/coreboot/+/39425/11/src/soc/intel/xeon_sp/acpi... PS11, Line 37: GPIO_BASE_SIZE
we do not have this defined, we need to find out this value for C620
This file was removed from the change. Marking as resolved.
https://review.coreboot.org/c/coreboot/+/39425/11/src/soc/intel/xeon_sp/acpi... PS11, Line 88: Subtract
Please use the new asl syntax where possible
This file was removed from the change. Marking as resolved.
https://review.coreboot.org/c/coreboot/+/39425/11/src/soc/intel/xeon_sp/incl... File src/soc/intel/xeon_sp/include/soc/lewisburg_pch_gpio_defs.h:
https://review.coreboot.org/c/coreboot/+/39425/11/src/soc/intel/xeon_sp/incl... PS11, Line 340: ALIGN_UP
Use DIV_ROUND_UP instead?
*poke*
-
Angel Pons (Code Review)